diff options
| author | jake <jake@FreeBSD.org> | 2000-12-23 19:43:10 +0000 |
|---|---|---|
| committer | jake <jake@FreeBSD.org> | 2000-12-23 19:43:10 +0000 |
| commit | fa7a58ab48542df270919dc02881d5c4a2d4f344 (patch) | |
| tree | 51c7f08e6064351afd60db7b45fcd14756284805 /sys/kern/kern_ktrace.c | |
| parent | 974f411f61d6549db784519d520f6a33719e3f6c (diff) | |
| download | FreeBSD-src-fa7a58ab48542df270919dc02881d5c4a2d4f344.zip FreeBSD-src-fa7a58ab48542df270919dc02881d5c4a2d4f344.tar.gz | |
Protect proc.p_pptr and proc.p_children/p_sibling with the
proctree_lock.
linprocfs not locked pending response from informal maintainer.
Reviewed by: jhb, -smp@
Diffstat (limited to 'sys/kern/kern_ktrace.c')
| -rw-r--r-- | sys/kern/kern_ktrace.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/sys/kern/kern_ktrace.c b/sys/kern/kern_ktrace.c index 59321fe..f0f187f 100644 --- a/sys/kern/kern_ktrace.c +++ b/sys/kern/kern_ktrace.c @@ -317,7 +317,6 @@ ktrace(curp, uap) ret |= ktrsetchildren(curp, p, ops, facs, vp); else ret |= ktrops(curp, p, ops, facs, vp); - } else { /* * by pid @@ -426,6 +425,7 @@ ktrsetchildren(curp, top, ops, facs, vp) register int ret = 0; p = top; + PROCTREE_LOCK(PT_SHARED); for (;;) { ret |= ktrops(curp, p, ops, facs, vp); /* @@ -436,8 +436,10 @@ ktrsetchildren(curp, top, ops, facs, vp) if (!LIST_EMPTY(&p->p_children)) p = LIST_FIRST(&p->p_children); else for (;;) { - if (p == top) + if (p == top) { + PROCTREE_LOCK(PT_RELEASE); return (ret); + } if (LIST_NEXT(p, p_sibling)) { p = LIST_NEXT(p, p_sibling); break; |
