diff options
| author | nwhitehorn <nwhitehorn@FreeBSD.org> | 2011-05-31 15:11:43 +0000 |
|---|---|---|
| committer | nwhitehorn <nwhitehorn@FreeBSD.org> | 2011-05-31 15:11:43 +0000 |
| commit | a69e106b2fac0817484b6b395a4bfcabef513310 (patch) | |
| tree | 02ea093d9809e917fd683ac9ee2c87d27aa454e6 /sys/kern/kern_idle.c | |
| parent | 3e43795a7a21a21ba53f04ea258e3e79a7a34e9d (diff) | |
| download | FreeBSD-src-a69e106b2fac0817484b6b395a4bfcabef513310.zip FreeBSD-src-a69e106b2fac0817484b6b395a4bfcabef513310.tar.gz | |
On multi-core, multi-threaded PPC systems, it is important that the threads
be brought up in the order they are enumerated in the device tree (in
particular, that thread 0 on each core be brought up first). The SLIST
through which we loop to start the CPUs has all of its entries added with
SLIST_INSERT_HEAD(), which means it is in reverse order of enumeration
and so AP startup would always fail in such situations (causing a machine
check or RTAS failure). Fix this by changing the SLIST into an STAILQ,
and inserting new CPUs at the end.
Reviewed by: jhb
Diffstat (limited to 'sys/kern/kern_idle.c')
| -rw-r--r-- | sys/kern/kern_idle.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/kern/kern_idle.c b/sys/kern/kern_idle.c index af12d7d..f412d17 100644 --- a/sys/kern/kern_idle.c +++ b/sys/kern/kern_idle.c @@ -60,7 +60,7 @@ idle_setup(void *dummy) p = NULL; /* start with no idle process */ #ifdef SMP - SLIST_FOREACH(pc, &cpuhead, pc_allcpu) { + STAILQ_FOREACH(pc, &cpuhead, pc_allcpu) { #endif #ifdef SMP error = kproc_kthread_add(sched_idletd, NULL, &p, &td, |
