Add new function fdunshare() which encapsulates the necessary light magic

for ensuring that a process' filedesc is not shared with anybody.

Use it in the two places which previously had private implmentations.

This collects all fd_refcnt handling in kern_descrip.c

1 files changed, 1 insertions, 10 deletions

diff --git a/sys/kern/kern_exec.c b/sys/kern/kern_exec.c
index e21cb00..40e0f0a 100644
--- a/sys/kern/kern_exec.c
+++ b/sys/kern/kern_exec.c
@@ -465,16 +465,7 @@ interpret:
 	 * For security and other reasons, the file descriptor table cannot
 	 * be shared after an exec.
 	 */
-	FILEDESC_LOCK_FAST(p->p_fd);
-	if (p->p_fd->fd_refcnt > 1) {
-		struct filedesc *tmp;
-
-		FILEDESC_UNLOCK_FAST(p->p_fd);
-		tmp = fdcopy(p->p_fd);
-		fdfree(td);
-		p->p_fd = tmp;
-	} else
-		FILEDESC_UNLOCK_FAST(p->p_fd);
+	fdunshare(p, td);
 
 	/*
 	 * Malloc things before we need locks.