diff options
| author | guido <guido@FreeBSD.org> | 1998-09-07 07:20:30 +0000 |
|---|---|---|
| committer | guido <guido@FreeBSD.org> | 1998-09-07 07:20:30 +0000 |
| commit | 9a709b57ca9f7ef9811416d85dd1b677a3312fbc (patch) | |
| tree | e6310b24bb138f3230f317fe243762dc88985d26 /sys/isofs | |
| parent | fcef0795af5d7071c203ebdf38f9a596f12359d1 (diff) | |
| download | FreeBSD-src-9a709b57ca9f7ef9811416d85dd1b677a3312fbc.zip FreeBSD-src-9a709b57ca9f7ef9811416d85dd1b677a3312fbc.tar.gz | |
Fix problem reported on bugtraq: check permission of device mounted
for non-root users. Fortunately, the default for vfs.usermount is 0.
Tested by: "Jan B. Koum " <jkb@best.com
Diffstat (limited to 'sys/isofs')
| -rw-r--r-- | sys/isofs/cd9660/cd9660_vfsops.c | 20 |
1 files changed, 19 insertions, 1 deletions
diff --git a/sys/isofs/cd9660/cd9660_vfsops.c b/sys/isofs/cd9660/cd9660_vfsops.c index b0bfca2..cc1672f 100644 --- a/sys/isofs/cd9660/cd9660_vfsops.c +++ b/sys/isofs/cd9660/cd9660_vfsops.c @@ -36,7 +36,7 @@ * SUCH DAMAGE. * * @(#)cd9660_vfsops.c 8.18 (Berkeley) 5/22/95 - * $Id: cd9660_vfsops.c,v 1.40 1998/06/07 17:11:29 dfr Exp $ + * $Id: cd9660_vfsops.c,v 1.41 1998/07/04 22:30:21 julian Exp $ */ #include <sys/param.h> @@ -199,6 +199,7 @@ cd9660_mount(mp, path, data, ndp, p) struct iso_args args; size_t size; int error; + mode_t accessmode; struct iso_mnt *imp = 0; #ifndef VFS_LKM /* mount root makes no sense to an LKM */ @@ -244,6 +245,23 @@ cd9660_mount(mp, path, data, ndp, p) vrele(devvp); return ENXIO; } + + /* + * If mount by non-root, then verify that user has necessary + * permissions on the device. + */ + if (p->p_ucred->cr_uid != 0) { + accessmode = VREAD; + if ((mp->mnt_flag & MNT_RDONLY) == 0) + accessmode |= VWRITE; + vn_lock(devvp, LK_EXCLUSIVE | LK_RETRY, p); + if (error = VOP_ACCESS(devvp, accessmode, p->p_ucred, p)) { + vput(devvp); + return (error); + } + VOP_UNLOCK(devvp, 0, p); + } + if ((mp->mnt_flag & MNT_UPDATE) == 0) { if (bdevsw[major(devvp->v_rdev)]->d_flags & D_NOCLUSTERR) mp->mnt_flag |= MNT_NOCLUSTERR; |
