diff options
| author | phk <phk@FreeBSD.org> | 2003-05-31 16:57:01 +0000 |
|---|---|---|
| committer | phk <phk@FreeBSD.org> | 2003-05-31 16:57:01 +0000 |
| commit | dc5b07a729fa86298afcafa5a2ff51ef51bcedd7 (patch) | |
| tree | 0aa3114c7dd732be838bd92f21e8eee8091b3dd9 /sys/i4b/layer1 | |
| parent | 170ff8a070ae09ddcfa76d7d4af98f69a84c177a (diff) | |
| download | FreeBSD-src-dc5b07a729fa86298afcafa5a2ff51ef51bcedd7.zip FreeBSD-src-dc5b07a729fa86298afcafa5a2ff51ef51bcedd7.tar.gz | |
Fix systematic off-by-one errors in unit number range checks.
Found by: FlexeLint
Diffstat (limited to 'sys/i4b/layer1')
| -rw-r--r-- | sys/i4b/layer1/ifpi/i4b_ifpi_pci.c | 4 | ||||
| -rw-r--r-- | sys/i4b/layer1/ifpi2/i4b_ifpi2_pci.c | 4 | ||||
| -rw-r--r-- | sys/i4b/layer1/ifpnp/i4b_ifpnp_avm.c | 4 | ||||
| -rw-r--r-- | sys/i4b/layer1/itjc/i4b_itjc_pci.c | 4 |
4 files changed, 8 insertions, 8 deletions
diff --git a/sys/i4b/layer1/ifpi/i4b_ifpi_pci.c b/sys/i4b/layer1/ifpi/i4b_ifpi_pci.c index 8ff860e..6ab166c 100644 --- a/sys/i4b/layer1/ifpi/i4b_ifpi_pci.c +++ b/sys/i4b/layer1/ifpi/i4b_ifpi_pci.c @@ -502,8 +502,8 @@ avma1pp_attach_avma1pp(device_t dev) bzero(sc, sizeof(struct l1_softc)); /* probably not really required */ - if(unit > IFPI_MAXUNIT) { - printf("avma1pp%d: Error, unit > IFPI_MAXUNIT!\n", unit); + if(unit >= IFPI_MAXUNIT) { + printf("avma1pp%d: Error, unit >= IFPI_MAXUNIT!\n", unit); splx(s); return(ENXIO); } diff --git a/sys/i4b/layer1/ifpi2/i4b_ifpi2_pci.c b/sys/i4b/layer1/ifpi2/i4b_ifpi2_pci.c index e0f855f..a6850fc 100644 --- a/sys/i4b/layer1/ifpi2/i4b_ifpi2_pci.c +++ b/sys/i4b/layer1/ifpi2/i4b_ifpi2_pci.c @@ -457,8 +457,8 @@ avma1pp2_attach_avma1pp(device_t dev) bzero(sc, sizeof(struct l1_softc)); /* probably not really required */ - if(unit > IFPI2_MAXUNIT) { - printf("ifpi2-%d: Error, unit > IFPI_MAXUNIT!\n", unit); + if(unit >= IFPI2_MAXUNIT) { + printf("ifpi2-%d: Error, unit >= IFPI_MAXUNIT!\n", unit); splx(s); return(ENXIO); } diff --git a/sys/i4b/layer1/ifpnp/i4b_ifpnp_avm.c b/sys/i4b/layer1/ifpnp/i4b_ifpnp_avm.c index 01cfc69..79678a8 100644 --- a/sys/i4b/layer1/ifpnp/i4b_ifpnp_avm.c +++ b/sys/i4b/layer1/ifpnp/i4b_ifpnp_avm.c @@ -470,8 +470,8 @@ avm_pnp_attach(device_t dev) bzero(sc, sizeof(struct l1_softc)); /* probably not really required */ - if(unit > IFPNP_MAXUNIT) { - printf("avm_pnp%d: Error, unit > IFPNP_MAXUNIT!\n", unit); + if(unit >= IFPNP_MAXUNIT) { + printf("avm_pnp%d: Error, unit >= IFPNP_MAXUNIT!\n", unit); splx(s); return(ENXIO); } diff --git a/sys/i4b/layer1/itjc/i4b_itjc_pci.c b/sys/i4b/layer1/itjc/i4b_itjc_pci.c index e1028fe..c023f36 100644 --- a/sys/i4b/layer1/itjc/i4b_itjc_pci.c +++ b/sys/i4b/layer1/itjc/i4b_itjc_pci.c @@ -1523,9 +1523,9 @@ itjc_attach(device_t dev) bzero(sc, sizeof(struct l1_softc)); /* Probably not really required. */ - if (unit > ITJC_MAXUNIT) + if (unit >= ITJC_MAXUNIT) { - printf("itjc%d: Error, unit > ITJC_MAXUNIT!\n", unit); + printf("itjc%d: Error, unit >= ITJC_MAXUNIT!\n", unit); splx(s); return ENXIO; } |
