Incorporate bde's code-review comments.

(a) bring back ttselect, now that we have xxxdevtotty() it isn't dangerous.
(b) remove all of the wrappers that have been replaced by ttselect
(c) fix formatting in syscons.c and definition in syscons.h
(d) add cxdevtotty

NOT DONE:
(e) make pcvt work... it was already broken...when someone fixes pcvt to
	link properly, just rename get_pccons to xxxdevtotty and we're done

1 files changed, 18 insertions, 1 deletions

diff --git a/sys/i386/isa/cx.c b/sys/i386/isa/cx.c
index f7a53fe..2ee5df8 100644
--- a/sys/i386/isa/cx.c
+++ b/sys/i386/isa/cx.c
@@ -671,6 +671,19 @@ int cxparam (struct tty *tp, struct termios *t)
 	splx (s);
 	return (0);
 }
+
+struct tty *cxdevtotty (dev_t dev)
+{
+	int unit = UNIT(dev);
+
+	if (unit == UNIT_CTL)
+		return (NULL);
+
+	if (unit > NCX*NCHAN)
+		return (NULL);
+
+	return (cxchan[unit]->ttyp);
+}
  
 int cxselect (dev_t dev, int flag, struct proc *p)
 {
@@ -678,7 +691,11 @@ int cxselect (dev_t dev, int flag, struct proc *p)
 
 	if (unit == UNIT_CTL)
 		return (0);
-	return (ttyselect (cxchan[unit]->ttyp, flag, p));
+
+	if (unit > NCX*NCHAN)
+		return (ENXIO);
+
+	return (ttyselect(cxchan[unit]->ttyp, flag, p));
 }
 
 /*