diff options
| author | archie <archie@FreeBSD.org> | 1998-12-04 22:54:57 +0000 |
|---|---|---|
| committer | archie <archie@FreeBSD.org> | 1998-12-04 22:54:57 +0000 |
| commit | 982e80577dd08945aa2345ebe35e3f50eef9eb48 (patch) | |
| tree | e21ff4cbfbcb4097c6cc444d68ddd9a3fd37837f /sys/i386/isa/bs | |
| parent | 707b8f68aa118c7396f2a2633751e32477d9ed08 (diff) | |
| download | FreeBSD-src-982e80577dd08945aa2345ebe35e3f50eef9eb48.zip FreeBSD-src-982e80577dd08945aa2345ebe35e3f50eef9eb48.tar.gz | |
Examine all occurrences of sprintf(), strcat(), and str[n]cpy()
for possible buffer overflow problems. Replaced most sprintf()'s
with snprintf(); for others cases, added terminating NUL bytes where
appropriate, replaced constants like "16" with sizeof(), etc.
These changes include several bug fixes, but most changes are for
maintainability's sake. Any instance where it wasn't "immediately
obvious" that a buffer overflow could not occur was made safer.
Reviewed by: Bruce Evans <bde@zeta.org.au>
Reviewed by: Matthew Dillon <dillon@apollo.backplane.com>
Reviewed by: Mike Spengler <mks@networkcs.com>
Diffstat (limited to 'sys/i386/isa/bs')
| -rw-r--r-- | sys/i386/isa/bs/bs_isa.c | 3 | ||||
| -rw-r--r-- | sys/i386/isa/bs/bsif.c | 2 |
2 files changed, 3 insertions, 2 deletions
diff --git a/sys/i386/isa/bs/bs_isa.c b/sys/i386/isa/bs/bs_isa.c index 7215de6..644dc0e 100644 --- a/sys/i386/isa/bs/bs_isa.c +++ b/sys/i386/isa/bs/bs_isa.c @@ -59,7 +59,8 @@ bs_args_copy(bsc, ia, hw) bsc->sm_offset = 0; bsc->sc_cfgflags = DVCFG_MINOR(ia->ia_cfgflags); - strcpy(bsc->sc_dvname, bsc->sc_dev.dv_xname); + snprintf(bsc->sc_dvname, sizeof(bsc->sc_dvname), + "%s", bsc->sc_dev.dv_xname); } static int diff --git a/sys/i386/isa/bs/bsif.c b/sys/i386/isa/bs/bsif.c index 58e7203..fc02971 100644 --- a/sys/i386/isa/bs/bsif.c +++ b/sys/i386/isa/bs/bsif.c @@ -158,7 +158,7 @@ bsprobe(dev) else bsc->sm_offset = (u_long) 0; - sprintf(bsc->sc_dvname, "bs%d", unit); + snprintf(bsc->sc_dvname, sizeof(bsc->sc_dvname), "bs%d", unit); if (dev->id_iobase == 0) { |
