diff options
| author | fsmp <fsmp@FreeBSD.org> | 1997-08-09 19:40:28 +0000 |
|---|---|---|
| committer | fsmp <fsmp@FreeBSD.org> | 1997-08-09 19:40:28 +0000 |
| commit | f1ff77939827ecbbd5c78086649e672c22e28836 (patch) | |
| tree | e55b0a62df0483f322a634c1485e003500d64957 /sys/i386/isa/apic_vector.s | |
| parent | 18323be74595d7ce91803e4b0879bacd887b3eb1 (diff) | |
| download | FreeBSD-src-f1ff77939827ecbbd5c78086649e672c22e28836.zip FreeBSD-src-f1ff77939827ecbbd5c78086649e672c22e28836.tar.gz | |
Added 'lock' instruction before 3 places that update ipending.
This may or may not fix the "high IO freezes SMP kernel" problem.
Diffstat (limited to 'sys/i386/isa/apic_vector.s')
| -rw-r--r-- | sys/i386/isa/apic_vector.s | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/sys/i386/isa/apic_vector.s b/sys/i386/isa/apic_vector.s index 0025231..2134552 100644 --- a/sys/i386/isa/apic_vector.s +++ b/sys/i386/isa/apic_vector.s @@ -1,6 +1,6 @@ /* * from: vector.s, 386BSD 0.1 unknown origin - * $Id: apic_vector.s,v 1.18 1997/07/30 22:46:49 smp Exp smp $ + * $Id: apic_vector.s,v 1.13 1997/07/31 05:42:05 fsmp Exp $ */ @@ -45,6 +45,7 @@ orl $IOART_INTMASK,%eax ; /* set the mask */ \ movl %eax,IOAPIC_WINDOW(%ecx) ; /* new value */ \ 7: ; \ + lock ; /* MP-safe */ \ orl $IRQ_BIT(irq_num), _ipending ; /* set _ipending bit */ \ IMASK_UNLOCK ; /* exit critical reg */ \ movl $0, lapic_eoi ; /* do the EOI */ \ @@ -70,6 +71,7 @@ movl IOAPIC_WINDOW(%ecx),%eax ; /* current value */ \ orl $IOART_INTMASK,%eax ; /* set the mask */ \ movl %eax,IOAPIC_WINDOW(%ecx) ; /* new value */ \ + lock ; /* MP-safe */ \ orl $IRQ_BIT(irq_num), _ipending ; /* set _ipending bit */ \ movl $0, lapic_eoi ; /* do the EOI */ \ IMASK_UNLOCK ; /* exit critical reg */ \ @@ -206,6 +208,7 @@ __CONCAT(Xresume,irq_num): ; \ ALIGN_TEXT ; \ 3: ; \ /* XXX skip mcounting here to avoid double count */ \ + lock ; /* MP-safe */ \ orl $IRQ_BIT(irq_num), _ipending ; \ REL_ISRLOCK(irq_num) ; \ popl %es ; \ |
