diff options
author | jdp <jdp@FreeBSD.org> | 2005-11-18 02:43:49 +0000 |
---|---|---|
committer | jdp <jdp@FreeBSD.org> | 2005-11-18 02:43:49 +0000 |
commit | 536960dbba6409b86ac8cba48c8eebec0ee4d3bc (patch) | |
tree | fd8fdcdbe252a0fea49dd01324b56a12740040f9 /sys/geom/geom_subr.c | |
parent | 1f2553e461911eee3bd762d61effbef7d0b8cc45 (diff) | |
download | FreeBSD-src-536960dbba6409b86ac8cba48c8eebec0ee4d3bc.zip FreeBSD-src-536960dbba6409b86ac8cba48c8eebec0ee4d3bc.tar.gz |
Fix a bug that caused some /dev entries to continue to exist after
the underlying drive had been hot-unplugged from the system. Here
is a specific example. Filesystem code had opened /dev/da1s1e.
Subsequently, the drive was hot-unplugged. This (correctly) caused
all of the associated /dev/da1* entries to be deleted. When the
filesystem later realized that the drive was gone it closed the
device, reducing the write-access counts to 0 on the geom providers
for da1s1e, da1s1, and da1. This caused geom to re-taste the
providers, resulting in the devices being created again. When the
drive was hot-plugged back in, it resulted in duplicate /dev entries
for da1s1e, da1s1, and da1.
This fix adds a new disk_gone() function which is called by CAM when a
drive goes away. It orphans all of the providers associated with the
drive, setting an error condition of ENXIO in each one. In addition,
we prevent a re-taste on last close for writing if an error condition
has been set in the provider.
Sponsored by: Isilon Systems
Reviewed by: phk
MFC after: 1 week
Diffstat (limited to 'sys/geom/geom_subr.c')
-rw-r--r-- | sys/geom/geom_subr.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/sys/geom/geom_subr.c b/sys/geom/geom_subr.c index 4af0d4a..8bedee9 100644 --- a/sys/geom/geom_subr.c +++ b/sys/geom/geom_subr.c @@ -734,11 +734,12 @@ g_access(struct g_consumer *cp, int dcr, int dcw, int dce) if (!error) { /* * If we open first write, spoil any partner consumers. - * If we close last write, trigger re-taste. + * If we close last write and provider is not errored, + * trigger re-taste. */ if (pp->acw == 0 && dcw != 0) g_spoil(pp, cp); - else if (pp->acw != 0 && pp->acw == -dcw && + else if (pp->acw != 0 && pp->acw == -dcw && pp->error == 0 && !(pp->geom->flags & G_GEOM_WITHER)) g_post_event(g_new_provider_event, pp, M_WAITOK, pp, NULL); |