summaryrefslogtreecommitdiffstats
path: root/sys/geom/geom_dev.c
diff options
context:
space:
mode:
authorphk <phk@FreeBSD.org>2002-12-26 20:45:37 +0000
committerphk <phk@FreeBSD.org>2002-12-26 20:45:37 +0000
commit3e75022eb741b6b3184df40cca41d27b285d676d (patch)
tree0d2506ca5c2fbdebe7068c40eee36151f8b048ab /sys/geom/geom_dev.c
parent99caa6f36af40ccb5f56b89ca9e73db42afbb0f9 (diff)
downloadFreeBSD-src-3e75022eb741b6b3184df40cca41d27b285d676d.zip
FreeBSD-src-3e75022eb741b6b3184df40cca41d27b285d676d.tar.gz
Add an XXX comment to explain the predicament.
Diffstat (limited to 'sys/geom/geom_dev.c')
-rw-r--r--sys/geom/geom_dev.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/sys/geom/geom_dev.c b/sys/geom/geom_dev.c
index 186b136..c258b86 100644
--- a/sys/geom/geom_dev.c
+++ b/sys/geom/geom_dev.c
@@ -101,6 +101,13 @@ g_dev_print(void)
return (1);
}
+/*
+ * XXX: This is disgusting and wrong in every way imaginable: The only reason
+ * XXX: we have a clone function is because of the root-mount hack we currently
+ * XXX: employ. An improvment would be to unregister this cloner once we know
+ * XXX: we no longer need it. Ideally, root-fs would be mounted through DEVFS
+ * XXX: eliminating the need for this hack.
+ */
static void
g_dev_clone(void *arg __unused, char *name, int namelen __unused, dev_t *dev)
{
@@ -111,7 +118,6 @@ g_dev_clone(void *arg __unused, char *name, int namelen __unused, dev_t *dev)
g_waitidle();
- /* XXX: can I drop Giant here ??? */
/* g_topology_lock(); */
LIST_FOREACH(gp, &g_dev_class.geom, geom) {
if (strcmp(gp->name, name))
OpenPOWER on IntegriCloud