diff options
author | ngie <ngie@FreeBSD.org> | 2017-01-13 09:19:04 +0000 |
---|---|---|
committer | ngie <ngie@FreeBSD.org> | 2017-01-13 09:19:04 +0000 |
commit | 1e83ccb86c47222e815a1121dda84135e2480e8d (patch) | |
tree | d0b114910287f21a3e2adb097f351c05055a661a /sys/fs/tmpfs/tmpfs_fifoops.c | |
parent | f33ac2bbf35e2da10c53d039c1614b46f559dc5b (diff) | |
download | FreeBSD-src-1e83ccb86c47222e815a1121dda84135e2480e8d.zip FreeBSD-src-1e83ccb86c47222e815a1121dda84135e2480e8d.tar.gz |
MFC r310586,r310587,r310588,r311381:
r310586:
Refactor transport sources a bit to facilitate changes coming down pipeline
Add recv callback to transport layer to better facilitate code reuse and
readability and for symmetry with send callback. Move recv_dgram and
recv_stream to udp_recv and lsock_recv, respectively, and make the
beforementioned functions recv callbacks for the udp and lsock transports,
respectively.
Consolidate the check_priv* functions in their relevant trans*.c source to
limit scope/use.
Note: this code is roughly based content from the submitter, although this
was modified to be more of a direct move from snmpd/main.c to the trans_*.c
sources, and to reduce unnecessary static function declarations.
r310587:
Fix definition for recv_dgram(..); it should be "ssize_t", not "int"
I'm not sure why this wasn't flagged as an issue by the compiler, yet
r310588:
Fix return type for `ret` (recv callback) and sort variables by alignment
Again, for reasons I don't yet understand, this is not being flagged by the
compiler. Unlike the issue addressed in r310587, this problem existed prior
to r310586
r311381:
lsock_init_port: address issues with initializing sockaddr_un object
- Use strlcpy to ensure p->name doesn't overflow sa.sun_path [*].
- Use SUN_LEN(..) instead of spelling out calculation longhand (inspired
by comment by jmallett).
Tested with: dgram and stream support with both bsnmpwalk and snmpwalk
CID: 1006825
Diffstat (limited to 'sys/fs/tmpfs/tmpfs_fifoops.c')
0 files changed, 0 insertions, 0 deletions