diff options
| author | tegge <tegge@FreeBSD.org> | 2006-09-26 04:12:49 +0000 |
|---|---|---|
| committer | tegge <tegge@FreeBSD.org> | 2006-09-26 04:12:49 +0000 |
| commit | 83154f853d9ca39deb1add01e032aff1f0678514 (patch) | |
| tree | ac46e0b5a80f88127d3d14dc940a5f2746573c00 /sys/fs/nullfs/null_vfsops.c | |
| parent | d7fe3e736512a1dd37a985037184eecf7df1f26d (diff) | |
| download | FreeBSD-src-83154f853d9ca39deb1add01e032aff1f0678514.zip FreeBSD-src-83154f853d9ca39deb1add01e032aff1f0678514.tar.gz | |
Use mount interlock to protect all changes to mnt_flag and mnt_kern_flag.
This eliminates a race where MNT_UPDATE flag could be lost when nmount()
raced against sync(), sync_fsync() or quotactl().
Diffstat (limited to 'sys/fs/nullfs/null_vfsops.c')
| -rw-r--r-- | sys/fs/nullfs/null_vfsops.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/sys/fs/nullfs/null_vfsops.c b/sys/fs/nullfs/null_vfsops.c index 505576b..125c67a 100644 --- a/sys/fs/nullfs/null_vfsops.c +++ b/sys/fs/nullfs/null_vfsops.c @@ -179,9 +179,14 @@ nullfs_mount(struct mount *mp, struct thread *td) */ VOP_UNLOCK(vp, 0, td); - if (NULLVPTOLOWERVP(nullm_rootvp)->v_mount->mnt_flag & MNT_LOCAL) + if (NULLVPTOLOWERVP(nullm_rootvp)->v_mount->mnt_flag & MNT_LOCAL) { + MNT_ILOCK(mp); mp->mnt_flag |= MNT_LOCAL; + MNT_IUNLOCK(mp); + } + MNT_ILOCK(mp); mp->mnt_kern_flag |= lowerrootvp->v_mount->mnt_kern_flag & MNTK_MPSAFE; + MNT_IUNLOCK(mp); mp->mnt_data = (qaddr_t) xmp; vfs_getnewfsid(mp); |
