diff options
author | bde <bde@FreeBSD.org> | 2004-02-14 04:41:13 +0000 |
---|---|---|
committer | bde <bde@FreeBSD.org> | 2004-02-14 04:41:13 +0000 |
commit | 4dca0a78ca378a90328358f3bfee84726fb0ad36 (patch) | |
tree | 461dd67fde6923278570d56f8130b249cad7da27 /sys/fs/msdosfs | |
parent | 67995bef83d9d8c84403dab3348106cf5b861d10 (diff) | |
download | FreeBSD-src-4dca0a78ca378a90328358f3bfee84726fb0ad36.zip FreeBSD-src-4dca0a78ca378a90328358f3bfee84726fb0ad36.tar.gz |
Fixed some style bugs:
- don't unlock the vnode after vinvalbuf() only to have to relock it
almost immediately.
- don't refer to devices classified by vn_isdisk() as block devices.
Diffstat (limited to 'sys/fs/msdosfs')
-rw-r--r-- | sys/fs/msdosfs/msdosfs_vfsops.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/sys/fs/msdosfs/msdosfs_vfsops.c b/sys/fs/msdosfs/msdosfs_vfsops.c index 12dd65c..edcdd2e 100644 --- a/sys/fs/msdosfs/msdosfs_vfsops.c +++ b/sys/fs/msdosfs/msdosfs_vfsops.c @@ -232,7 +232,7 @@ msdosfs_mount(mp, path, data, ndp, td) } /* * Not an update, or updating the name: look up the name - * and verify that it refers to a sensible block device. + * and verify that it refers to a sensible disk device. */ NDINIT(ndp, LOOKUP, FOLLOW, UIO_USERSPACE, args.fspec, td); error = namei(ndp); @@ -323,12 +323,12 @@ mountmsdosfs(devvp, mp, td, argp) return (EBUSY); vn_lock(devvp, LK_EXCLUSIVE | LK_RETRY, td); error = vinvalbuf(devvp, V_SAVE, td->td_ucred, td, 0, 0); - VOP_UNLOCK(devvp, 0, td); - if (error) + if (error) { + VOP_UNLOCK(devvp, 0, td); return (error); + } ronly = (mp->mnt_flag & MNT_RDONLY) != 0; - vn_lock(devvp, LK_EXCLUSIVE | LK_RETRY, td); /* * XXX: open the device with read and write access even if only * read access is needed now. Write access is needed if the |