diff options
| author | pjd <pjd@FreeBSD.org> | 2007-07-26 16:58:09 +0000 |
|---|---|---|
| committer | pjd <pjd@FreeBSD.org> | 2007-07-26 16:58:09 +0000 |
| commit | fe74e944d12452785490f4343dd388287bc64da4 (patch) | |
| tree | 5a98f364f3abdf11cc44ba4d0cfc643ff591bd63 /sys/fs/fifofs | |
| parent | 8dc8d42bdcbcf383b19e382acdec9adc0bd70d90 (diff) | |
| download | FreeBSD-src-fe74e944d12452785490f4343dd388287bc64da4.zip FreeBSD-src-fe74e944d12452785490f4343dd388287bc64da4.tar.gz | |
When we do open, we should lock the vnode exclusively. This fixes few races:
- fifo race, where two threads assign v_fifoinfo,
- v_writecount modifications,
- v_object modifications,
- and probably more...
Discussed with: kib, ups
Approved by: re (rwatson)
Diffstat (limited to 'sys/fs/fifofs')
| -rw-r--r-- | sys/fs/fifofs/fifo_vnops.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/fs/fifofs/fifo_vnops.c b/sys/fs/fifofs/fifo_vnops.c index 7161591..2d3254f 100644 --- a/sys/fs/fifofs/fifo_vnops.c +++ b/sys/fs/fifofs/fifo_vnops.c @@ -179,7 +179,7 @@ fifo_open(ap) struct socket *rso, *wso; int error; - ASSERT_VOP_LOCKED(vp, "fifo_open"); + ASSERT_VOP_ELOCKED(vp, "fifo_open"); if (fp == NULL) return (EINVAL); if ((fip = vp->v_fifoinfo) == NULL) { |
