Merge the dev_clone and dev_clone_cred event handlers into a single

event handler, dev_clone, which accepts a credential argument.
Implementors of the event can ignore it if they're not interested,
and most do.  This avoids having multiple event handler types and
fall-back/precedence logic in devfs.

This changes the kernel API for /dev cloning, and may affect third
party packages containg cloning kernel modules.

Requested by:	phk
MFC after:	3 days

1 files changed, 4 insertions, 7 deletions

diff --git a/sys/fs/devfs/devfs_vnops.c b/sys/fs/devfs/devfs_vnops.c
index 34e78d9..8f14bcf 100644
--- a/sys/fs/devfs/devfs_vnops.c
+++ b/sys/fs/devfs/devfs_vnops.c
@@ -705,13 +705,10 @@ devfs_lookupx(ap)
 		goto notfound;
 
 	cdev = NULL;
-	EVENTHANDLER_INVOKE(dev_clone_cred, td->td_ucred, pname,
-	    strlen(pname), &cdev);
-	if (cdev == NULL) {
-		EVENTHANDLER_INVOKE(dev_clone, pname, strlen(pname), &cdev);
-		if (cdev == NULL)
-			goto notfound;
-	}
+	EVENTHANDLER_INVOKE(dev_clone, td->td_ucred, pname, strlen(pname),
+	    &cdev);
+	if (cdev == NULL)
+		goto notfound;
 
 	devfs_populate(dmp);