Do a pass over all modules in the kernel and make them return EOPNOTSUPP

for unknown events.

A number of modules return EINVAL in this instance, and I have left
those alone for now and instead taught MOD_QUIESCE to accept this
as "didn't do anything".

20 files changed, 32 insertions, 1 deletions

diff --git a/sys/dev/aic7xxx/aic79xx_osm.c b/sys/dev/aic7xxx/aic79xx_osm.c
index bbe07f6..921bae9 100644
--- a/sys/dev/aic7xxx/aic79xx_osm.c
+++ b/sys/dev/aic7xxx/aic79xx_osm.c
@@ -1540,6 +1540,7 @@ static int
 ahd_modevent(module_t mod, int type, void *data)
 {
 	/* XXX Deal with busy status on unload. */
+	/* XXX Deal with unknown events */
 	return 0;
 }
   
diff --git a/sys/dev/aic7xxx/aic7xxx_osm.c b/sys/dev/aic7xxx/aic7xxx_osm.c
index 3034f9b..1c11f76 100644
--- a/sys/dev/aic7xxx/aic7xxx_osm.c
+++ b/sys/dev/aic7xxx/aic7xxx_osm.c
@@ -1663,6 +1663,7 @@ static int
 ahc_modevent(module_t mod, int type, void *data)
 {
 	/* XXX Deal with busy status on unload. */
+	/* XXX Deal with unknown events */
 	return 0;
 }
   
diff --git a/sys/dev/bktr/bktr_mem.c b/sys/dev/bktr/bktr_mem.c
index 278e6b8..3adacce 100644
--- a/sys/dev/bktr/bktr_mem.c
+++ b/sys/dev/bktr/bktr_mem.c
@@ -88,6 +88,7 @@ bktr_mem_modevent(module_t mod, int type, void *unused){
 		printf("bktr_mem: memory holder cannot be unloaded\n");
 		return EBUSY;
 	default:
+		return EOPNOTSUPP;
 		break;
 	}
 	return (0);
diff --git a/sys/dev/dcons/dcons.c b/sys/dev/dcons/dcons.c
index 25494a0..2677444 100644
--- a/sys/dev/dcons/dcons.c
+++ b/sys/dev/dcons/dcons.c
@@ -651,6 +651,9 @@ dcons_modevent(module_t mode, int type, void *data)
 		break;
 	case MOD_SHUTDOWN:
 		break;
+	default:
+		err = EOPNOTSUPP;
+		break;
 	}
 	return(err);
 }
diff --git a/sys/dev/fb/fb.c b/sys/dev/fb/fb.c
index 38b9670..0878feb 100644
--- a/sys/dev/fb/fb.c
+++ b/sys/dev/fb/fb.c
@@ -386,6 +386,8 @@ fb_modevent(module_t mod, int type, void *data)
 	case MOD_UNLOAD: 
 		printf("fb module unload - not possible for this module type\n"); 
 		return EINVAL; 
+	default:
+		return EOPNOTSUPP;
 	} 
 	return 0; 
 } 
diff --git a/sys/dev/fb/splashreg.h b/sys/dev/fb/splashreg.h
index 05e5687..36ba9a7 100644
--- a/sys/dev/fb/splashreg.h
+++ b/sys/dev/fb/splashreg.h
@@ -55,6 +55,7 @@ typedef struct image_decoder	scrn_saver_t;
 		case MOD_UNLOAD:				\
 			return splash_unregister(&sw);		\
 		default:					\
+			return EOPNOTSUPP;			\
 			break;					\
 		}						\
 		return 0;					\
@@ -76,6 +77,7 @@ typedef struct image_decoder	scrn_saver_t;
 		case MOD_UNLOAD:				\
 			return splash_unregister(&sw);		\
 		default:					\
+			return EOPNOTSUPP;			\
 			break;					\
 		}						\
 		return 0;					\
diff --git a/sys/dev/firewire/firewire.c b/sys/dev/firewire/firewire.c
index 6342a18..9bd5dd6 100644
--- a/sys/dev/firewire/firewire.c
+++ b/sys/dev/firewire/firewire.c
@@ -2273,6 +2273,8 @@ fw_modevent(module_t mode, int type, void *data)
 		break;
 	case MOD_SHUTDOWN:
 		break;
+	default:
+		return (EOPNOTSUPP);
 	}
 	return (err);
 }
diff --git a/sys/dev/harp/if_harp.c b/sys/dev/harp/if_harp.c
index 87711b9..435b64e 100644
--- a/sys/dev/harp/if_harp.c
+++ b/sys/dev/harp/if_harp.c
@@ -646,6 +646,8 @@ harp_modevent(module_t mod, int event, void *data)
 		uma_zdestroy(harp_vcc_zone);
 
 		break;
+	  default:
+		return (EOPNOTSUPP);
 	}
 	return (0);
 }
diff --git a/sys/dev/hfa/hfa_freebsd.c b/sys/dev/hfa/hfa_freebsd.c
index 48a15ac..34db172 100644
--- a/sys/dev/hfa/hfa_freebsd.c
+++ b/sys/dev/hfa/hfa_freebsd.c
@@ -451,6 +451,7 @@ hfa_modevent (module_t mod, int type, void *data)
 
 		break;
 	default:
+		return (EOPNOTSUPP);
 		break;
 	}
 
diff --git a/sys/dev/ispfw/ispfw.c b/sys/dev/ispfw/ispfw.c
index f0b0a4d..633fdf7 100644
--- a/sys/dev/ispfw/ispfw.c
+++ b/sys/dev/ispfw/ispfw.c
@@ -164,6 +164,7 @@ isp_module_handler(module_t mod, int what, void *arg)
 		}
 		break;
 	default:
+		return (EOPNOTSUPP);
 		break;
 	}
 	return (0);
diff --git a/sys/dev/md/md.c b/sys/dev/md/md.c
index 295d8d2..e6dc8b5 100644
--- a/sys/dev/md/md.c
+++ b/sys/dev/md/md.c
@@ -1237,6 +1237,7 @@ md_modevent(module_t mod, int type, void *data)
 		status_dev = 0;
 		break;
 	default:
+		return (EOPNOTSUPP);
 		break;
 	}
 	return (0);
diff --git a/sys/dev/null/null.c b/sys/dev/null/null.c
index 14841d3..4f7bd9c 100644
--- a/sys/dev/null/null.c
+++ b/sys/dev/null/null.c
@@ -135,6 +135,8 @@ null_modevent(module_t mod __unused, int type, void *data __unused)
 	case MOD_SHUTDOWN:
 		break;
 
+	default:
+		return (EOPNOTSUPP);
 	}
 
 	return (0);
diff --git a/sys/dev/ofw/openpromio.c b/sys/dev/ofw/openpromio.c
index 3182bff..b2e3454 100644
--- a/sys/dev/ofw/openpromio.c
+++ b/sys/dev/ofw/openpromio.c
@@ -215,7 +215,7 @@ openprom_modevent(module_t mode, int type, void *data)
 		destroy_dev(openprom_dev);
 		return (0);
 	default:
-		return (0);
+		return (EOPNOTSUPP);
 	}
 }
 
diff --git a/sys/dev/random/randomdev.c b/sys/dev/random/randomdev.c
index 7c5434e..28cddd9 100644
--- a/sys/dev/random/randomdev.c
+++ b/sys/dev/random/randomdev.c
@@ -220,6 +220,10 @@ random_modevent(module_t mod __unused, int type, void *data __unused)
 	case MOD_SHUTDOWN:
 		break;
 
+	default:
+		error = EOPNOTSUPP;
+		break;
+
 	}
 	return (error);
 }
diff --git a/sys/dev/snp/snp.c b/sys/dev/snp/snp.c
index 3d4b2d4..a352707 100644
--- a/sys/dev/snp/snp.c
+++ b/sys/dev/snp/snp.c
@@ -650,6 +650,7 @@ snp_modevent(mod, type, data)
 		ldisc_deregister(snooplinedisc);
 		break;
 	default:
+		return (EOPNOTSUPP);
 		break;
 	}
 	return (0);
diff --git a/sys/dev/sound/driver.c b/sys/dev/sound/driver.c
index 57427d6..f995266 100644
--- a/sys/dev/sound/driver.c
+++ b/sys/dev/sound/driver.c
@@ -38,6 +38,7 @@ snd_modevent(module_t mod, int type, void *data)
 	case MOD_UNLOAD:
 		break;
 	default:
+		return (EOPNOTSUPP);
 		break;
 	}
 	return 0;
diff --git a/sys/dev/streams/streams.c b/sys/dev/streams/streams.c
index 8ef790d..1df0952 100644
--- a/sys/dev/streams/streams.c
+++ b/sys/dev/streams/streams.c
@@ -165,6 +165,7 @@ streams_modevent(module_t mod, int type, void *unused)
 
 		return 0;
 	default:
+		return EOPNOTSUPP;
 		break;
 	}
 	return 0;
diff --git a/sys/dev/syscons/syscons.h b/sys/dev/syscons/syscons.h
index 1651ad8..29909f9 100644
--- a/sys/dev/syscons/syscons.h
+++ b/sys/dev/syscons/syscons.h
@@ -391,6 +391,7 @@ typedef struct sc_term_sw {
 				return EBUSY;			\
 			return sc_term_remove(&sw);		\
 		default:					\
+			return EOPNOTSUPP;			\
 			break;					\
 		}						\
 		return 0;					\
@@ -462,6 +463,7 @@ typedef struct sc_renderer {
 			}					\
 			break;					\
 		default:					\
+			return EOPNOTSUPP;			\
 			break;					\
 		}						\
 		return error;					\
diff --git a/sys/dev/utopia/utopia.c b/sys/dev/utopia/utopia.c
index c648349..263f4b9 100644
--- a/sys/dev/utopia/utopia.c
+++ b/sys/dev/utopia/utopia.c
@@ -1550,6 +1550,8 @@ utopia_mod_init(module_t mod, int what, void *arg)
 			UTP_WUNLOCK_LIST();
 		mtx_destroy(&utopia_list_mtx);
 		break;
+	  default:
+		return (EOPNOTSUPP);
 	}
 	return (0);
 }
diff --git a/sys/dev/vinum/vinum.c b/sys/dev/vinum/vinum.c
index 062176b..5fb990d 100644
--- a/sys/dev/vinum/vinum.c
+++ b/sys/dev/vinum/vinum.c
@@ -318,6 +318,7 @@ vinum_modevent(module_t mod, modeventtype_t type, void *unused)
 	EVENTHANDLER_DEREGISTER(dev_clone, dev_clone_tag);
 	return 0;
     default:
+	return EOPNOTSUPP;
 	break;
     }
     return 0;