diff options
| author | royger <royger@FreeBSD.org> | 2016-02-11 11:50:31 +0000 |
|---|---|---|
| committer | royger <royger@FreeBSD.org> | 2016-02-11 11:50:31 +0000 |
| commit | b78ed75c2c7c3a3fc3a45961a65b7527f8ca07db (patch) | |
| tree | 7c17545d04b1637ce35e357aa6ff912b02389ee6 /sys/dev | |
| parent | c53e320c2be6eebf1949ef58119c1c7b085b3ede (diff) | |
| download | FreeBSD-src-b78ed75c2c7c3a3fc3a45961a65b7527f8ca07db.zip FreeBSD-src-b78ed75c2c7c3a3fc3a45961a65b7527f8ca07db.tar.gz | |
xen-netfront: remove pointless assignment in xn_ioctl
The variable error is assigned to 0 before entering the switch.
Assigning error to 0 before break pointless rewrites the real error
value that should be returned.
Coverity ID: 1304974
Submitted by: Wei Liu <wei.liu2@citrix.com>
Reviewed by: royger
Sponsored by: Citrix Systems R&D
Differential revision: https://reviews.freebsd.org/D5250
Diffstat (limited to 'sys/dev')
| -rw-r--r-- | sys/dev/xen/netfront/netfront.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/sys/dev/xen/netfront/netfront.c b/sys/dev/xen/netfront/netfront.c index e940d93..89aef62 100644 --- a/sys/dev/xen/netfront/netfront.c +++ b/sys/dev/xen/netfront/netfront.c @@ -1863,7 +1863,6 @@ xn_ioctl(struct ifnet *ifp, u_long cmd, caddr_t data) } sc->xn_if_flags = ifp->if_flags; XN_UNLOCK(sc); - error = 0; break; case SIOCSIFCAP: mask = ifr->ifr_reqcap ^ ifp->if_capenable; @@ -1898,7 +1897,6 @@ xn_ioctl(struct ifnet *ifp, u_long cmd, caddr_t data) ifp->if_capenable ^= IFCAP_LRO; } - error = 0; break; case SIOCADDMULTI: case SIOCDELMULTI: |
