summaryrefslogtreecommitdiffstats
path: root/sys/dev/xe/if_xe.c
diff options
context:
space:
mode:
authorrwatson <rwatson@FreeBSD.org>2005-08-03 00:18:35 +0000
committerrwatson <rwatson@FreeBSD.org>2005-08-03 00:18:35 +0000
commit9918d13b80941400bfab87834b1e2f1eea58c7c7 (patch)
tree9a4e586ffbcd1450917ee5e388a4e1eb38254e32 /sys/dev/xe/if_xe.c
parentefa13b9da9fc80838e2c73140ae27393b3660da4 (diff)
downloadFreeBSD-src-9918d13b80941400bfab87834b1e2f1eea58c7c7.zip
FreeBSD-src-9918d13b80941400bfab87834b1e2f1eea58c7c7.tar.gz
Modify device drivers supporting multicast addresses to lock if_addr_mtx
over iteration of their multicast address lists when synchronizing the hardware address filter with the network stack-maintained list. Problem reported by: Ed Maste (emaste at phaedrus dot sandvine dot ca> MFC after: 1 week
Diffstat (limited to 'sys/dev/xe/if_xe.c')
-rw-r--r--sys/dev/xe/if_xe.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/sys/dev/xe/if_xe.c b/sys/dev/xe/if_xe.c
index f95295f..4385fec 100644
--- a/sys/dev/xe/if_xe.c
+++ b/sys/dev/xe/if_xe.c
@@ -1274,6 +1274,7 @@ xe_set_multicast(struct xe_softc *scp) {
/* Iterate over multicast address list */
count = 0;
+ IF_ADDR_LOCK(ifp);
#if __FreeBSD_version < 500000
LIST_FOREACH(maddr, &ifp->if_multiaddrs, ifma_link) {
#else
@@ -1295,6 +1296,7 @@ xe_set_multicast(struct xe_softc *scp) {
/* Nowhere else to put them on CE2 */
break;
}
+ IF_ADDR_UNLOCK(ifp);
DEVPRINTF(2, (scp->dev, "set_multicast: count = %u\n", count));
OpenPOWER on IntegriCloud