summaryrefslogtreecommitdiffstats
path: root/sys/dev/usb/usb_pf.c
diff options
context:
space:
mode:
authorhrs <hrs@FreeBSD.org>2012-07-11 02:57:32 +0000
committerhrs <hrs@FreeBSD.org>2012-07-11 02:57:32 +0000
commitaf9d0513949580fb1bceef338353bbba8083cec0 (patch)
tree3b19022fe3a8020b5741d542ee7572a2cae0167c /sys/dev/usb/usb_pf.c
parent6183c30d852bea67cae2dfe81fe1a68eddc6f7a4 (diff)
downloadFreeBSD-src-af9d0513949580fb1bceef338353bbba8083cec0.zip
FreeBSD-src-af9d0513949580fb1bceef338353bbba8083cec0.tar.gz
Merge from r234532:
- Fix an ifname matching issue which prevented "ifconfig wlan0 create" from working. - Return non-zero status when unit < 0. Spotted by: dhw
Diffstat (limited to 'sys/dev/usb/usb_pf.c')
-rw-r--r--sys/dev/usb/usb_pf.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/sys/dev/usb/usb_pf.c b/sys/dev/usb/usb_pf.c
index 4c88051..b7b29d7 100644
--- a/sys/dev/usb/usb_pf.c
+++ b/sys/dev/usb/usb_pf.c
@@ -129,7 +129,7 @@ usbpf_ifname2ubus(const char *ifname)
int unit;
int error;
- if (strncmp(ifname, USBUSNAME, sizeof(USBUSNAME)) <= 0)
+ if (strncmp(ifname, USBUSNAME, sizeof(USBUSNAME) - 1) != 0)
return (NULL);
error = ifc_name2unit(ifname, &unit);
if (error || unit < 0)
@@ -167,8 +167,10 @@ usbpf_clone_create(struct if_clone *ifc, char *name, size_t len, caddr_t params)
struct usb_bus *ubus;
error = ifc_name2unit(name, &unit);
- if (error || unit < 0)
+ if (error)
return (error);
+ if (unit < 0)
+ return (EINVAL);
ubus = usbpf_ifname2ubus(name);
if (ubus == NULL)
OpenPOWER on IntegriCloud