diff options
| author | yongari <yongari@FreeBSD.org> | 2011-10-17 19:51:38 +0000 |
|---|---|---|
| committer | yongari <yongari@FreeBSD.org> | 2011-10-17 19:51:38 +0000 |
| commit | b773d9298b4e00625c15d55e3c71f9ce2b72972e (patch) | |
| tree | 4dae49a099c250da9471a581badd0370b5e3219c /sys/dev/usb/net/if_udav.c | |
| parent | 4c371e596be040085df1b5f9e469ab9fd8278c89 (diff) | |
| download | FreeBSD-src-b773d9298b4e00625c15d55e3c71f9ce2b72972e.zip FreeBSD-src-b773d9298b4e00625c15d55e3c71f9ce2b72972e.tar.gz | |
Close a race where SIOCGIFMEDIA ioctl get inconsistent link status.
Because driver is accessing a common MII structure in
mii_pollstat(), updating user supplied structure should be done
before dropping a driver lock.
Reported by: Karim (fodillemlinkarimi <> gmail dot com)
Diffstat (limited to 'sys/dev/usb/net/if_udav.c')
| -rw-r--r-- | sys/dev/usb/net/if_udav.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/dev/usb/net/if_udav.c b/sys/dev/usb/net/if_udav.c index ea35127..e9a0504 100644 --- a/sys/dev/usb/net/if_udav.c +++ b/sys/dev/usb/net/if_udav.c @@ -751,9 +751,9 @@ udav_ifmedia_status(struct ifnet *ifp, struct ifmediareq *ifmr) UDAV_LOCK(sc); mii_pollstat(mii); - UDAV_UNLOCK(sc); ifmr->ifm_active = mii->mii_media_active; ifmr->ifm_status = mii->mii_media_status; + UDAV_UNLOCK(sc); } static void |
