diff options
| author | kevlo <kevlo@FreeBSD.org> | 2013-06-14 05:36:47 +0000 |
|---|---|---|
| committer | kevlo <kevlo@FreeBSD.org> | 2013-06-14 05:36:47 +0000 |
| commit | a80685b9ce0c47ca222eb9c637898898cffa7752 (patch) | |
| tree | b2a11f5b9d79d6ff49428c1332757926c07d39f9 /sys/dev/usb/net/if_rue.c | |
| parent | 1f0a53a66f87e788b7ce601706e85f6b04724261 (diff) | |
| download | FreeBSD-src-a80685b9ce0c47ca222eb9c637898898cffa7752.zip FreeBSD-src-a80685b9ce0c47ca222eb9c637898898cffa7752.tar.gz | |
- Use the consistenly PHY-specific reset routine PHY_RESET() rather than
generic mii_phy_reset().
- Return the result of mii_mediachg() rather than blindly returning 0.
- on smsc(4), driver lock should be held to get current
mii_media_active/mii_media_status value.
Reviewed by: yongari
Diffstat (limited to 'sys/dev/usb/net/if_rue.c')
| -rw-r--r-- | sys/dev/usb/net/if_rue.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/sys/dev/usb/net/if_rue.c b/sys/dev/usb/net/if_rue.c index a08d851..17f82b0 100644 --- a/sys/dev/usb/net/if_rue.c +++ b/sys/dev/usb/net/if_rue.c @@ -866,14 +866,15 @@ rue_ifmedia_upd(struct ifnet *ifp) struct rue_softc *sc = ifp->if_softc; struct mii_data *mii = GET_MII(sc); struct mii_softc *miisc; + int error; RUE_LOCK_ASSERT(sc, MA_OWNED); sc->sc_flags &= ~RUE_FLAG_LINK; LIST_FOREACH(miisc, &mii->mii_phys, mii_list) PHY_RESET(miisc); - mii_mediachg(mii); - return (0); + error = mii_mediachg(mii); + return (error); } /* |
