summaryrefslogtreecommitdiffstats
path: root/sys/dev/sound
diff options
context:
space:
mode:
authormarius <marius@FreeBSD.org>2011-02-09 11:28:57 +0000
committermarius <marius@FreeBSD.org>2011-02-09 11:28:57 +0000
commit5a89aa1d25bb6391c07005ce951b3307655f7035 (patch)
tree203d920dec091258014cdea2c6e6ac1073d8b943 /sys/dev/sound
parenta0871da5952ea5fc5738b8152f40fb01030814dd (diff)
downloadFreeBSD-src-5a89aa1d25bb6391c07005ce951b3307655f7035.zip
FreeBSD-src-5a89aa1d25bb6391c07005ce951b3307655f7035.tar.gz
Correct signedness and off-by-one issues in parameters used for DMA tag
creation. PR: 154259 Submitted by: Vladislav Movchan (partially) MFC after: 3 days
Diffstat (limited to 'sys/dev/sound')
-rw-r--r--sys/dev/sound/pci/emu10k1.c2
-rw-r--r--sys/dev/sound/pci/emu10kx.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/sys/dev/sound/pci/emu10k1.c b/sys/dev/sound/pci/emu10k1.c
index 43b7ebe..4c02fa4 100644
--- a/sys/dev/sound/pci/emu10k1.c
+++ b/sys/dev/sound/pci/emu10k1.c
@@ -2017,7 +2017,7 @@ emu_pci_attach(device_t dev)
if (bus_dma_tag_create(/*parent*/bus_get_dma_tag(dev), /*alignment*/2,
/*boundary*/0,
- /*lowaddr*/1 << 31, /* can only access 0-2gb */
+ /*lowaddr*/(1U << 31) - 1, /* can only access 0-2gb */
/*highaddr*/BUS_SPACE_MAXADDR,
/*filter*/NULL, /*filterarg*/NULL,
/*maxsize*/sc->bufsz, /*nsegments*/1, /*maxsegz*/0x3ffff,
diff --git a/sys/dev/sound/pci/emu10kx.c b/sys/dev/sound/pci/emu10kx.c
index f1d10ed..c7ac57f 100644
--- a/sys/dev/sound/pci/emu10kx.c
+++ b/sys/dev/sound/pci/emu10kx.c
@@ -2700,7 +2700,7 @@ emu_init(struct emu_sc_info *sc)
if (bus_dma_tag_create( /* parent */ bus_get_dma_tag(sc->dev),
/* alignment */ 2, /* boundary */ 0,
- /* lowaddr */ 1 << 31, /* can only access 0-2gb */
+ /* lowaddr */ (1U << 31) - 1, /* can only access 0-2gb */
/* highaddr */ BUS_SPACE_MAXADDR,
/* filter */ NULL, /* filterarg */ NULL,
/* maxsize */ EMU_MAX_BUFSZ, /* nsegments */ 1, /* maxsegz */ 0x3ffff,
OpenPOWER on IntegriCloud