diff options
| author | ed <ed@FreeBSD.org> | 2008-09-26 14:19:52 +0000 |
|---|---|---|
| committer | ed <ed@FreeBSD.org> | 2008-09-26 14:19:52 +0000 |
| commit | 4212d51a7da942b0c717c9965552c9549d90de08 (patch) | |
| tree | f45f750affeffb39e162226343b0db9a110c42ce /sys/dev/sound/pcm/mixer.c | |
| parent | 0a873f95fe4b1e8d5d3f6ead357fca828948b3ac (diff) | |
| download | FreeBSD-src-4212d51a7da942b0c717c9965552c9549d90de08.zip FreeBSD-src-4212d51a7da942b0c717c9965552c9549d90de08.tar.gz | |
Remove unit2minor() use from kernel code.
When I changed kern_conf.c three months ago I made device unit numbers
equal to (unneeded) device minor numbers. We used to require
bitshifting, because there were eight bits in the middle that were
reserved for a device major number. Not very long after I turned
dev2unit(), minor(), unit2minor() and minor2unit() into macro's.
The unit2minor() and minor2unit() macro's were no-ops.
We'd better not remove these four macro's from the kernel, because there
is a lot of (external) code that may still depend on them. For now it's
harmless to remove all invocations of unit2minor() and minor2unit().
Reviewed by: kib
Diffstat (limited to 'sys/dev/sound/pcm/mixer.c')
| -rw-r--r-- | sys/dev/sound/pcm/mixer.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/dev/sound/pcm/mixer.c b/sys/dev/sound/pcm/mixer.c index 6196817..c3ca4f0 100644 --- a/sys/dev/sound/pcm/mixer.c +++ b/sys/dev/sound/pcm/mixer.c @@ -644,7 +644,7 @@ mixer_init(device_t dev, kobj_class_t cls, void *devinfo) unit = device_get_unit(dev); devunit = snd_mkunit(unit, SND_DEV_CTL, 0); - pdev = make_dev(&mixer_cdevsw, unit2minor(devunit), + pdev = make_dev(&mixer_cdevsw, devunit, UID_ROOT, GID_WHEEL, 0666, "mixer%d", unit); pdev->si_drv1 = m; snddev = device_get_softc(dev); |
