- Do not uiomove with a mutex locked.

- Move from msleep/wakeup to condvar.

- Return either zero or a positive errno value from a function.
  Return additional result via references.

- Unify the typedef of callback functions.

1 files changed, 2 insertions, 4 deletions

diff --git a/sys/dev/sound/midi/sequencer.h b/sys/dev/sound/midi/sequencer.h
index a81e041..ea75a36 100644
--- a/sys/dev/sound/midi/sequencer.h
+++ b/sys/dev/sound/midi/sequencer.h
@@ -68,8 +68,6 @@
 
 typedef struct _seqdev_info seqdev_info;
 
-typedef int (seq_callback_t)(seqdev_info *sd, int reason);
-
 /*
  * The order of mutex lock (from the first to the last)
  *
@@ -101,7 +99,7 @@ struct _seqdev_info {
 	d_write_t *write;
 	d_ioctl_t *ioctl;
 	d_poll_t *poll;
-	seq_callback_t *callback;
+	midi_callback_t *callback;
 
 	/*
 	 * combinations of the following flags are used as second argument in
@@ -234,7 +232,7 @@ struct _seqdev_info {
 /*
  * finally, all default parameters
  */
-#define SEQ_BUFFSIZE (4 * 1024) /* XXX */
+#define SEQ_BUFFSIZE (1024) /* XXX */
 
 /*
  * some macros for debugging purposes