summaryrefslogtreecommitdiffstats
path: root/sys/dev/sk
diff options
context:
space:
mode:
authorrwatson <rwatson@FreeBSD.org>2005-08-03 00:18:35 +0000
committerrwatson <rwatson@FreeBSD.org>2005-08-03 00:18:35 +0000
commit9918d13b80941400bfab87834b1e2f1eea58c7c7 (patch)
tree9a4e586ffbcd1450917ee5e388a4e1eb38254e32 /sys/dev/sk
parentefa13b9da9fc80838e2c73140ae27393b3660da4 (diff)
downloadFreeBSD-src-9918d13b80941400bfab87834b1e2f1eea58c7c7.zip
FreeBSD-src-9918d13b80941400bfab87834b1e2f1eea58c7c7.tar.gz
Modify device drivers supporting multicast addresses to lock if_addr_mtx
over iteration of their multicast address lists when synchronizing the hardware address filter with the network stack-maintained list. Problem reported by: Ed Maste (emaste at phaedrus dot sandvine dot ca> MFC after: 1 week
Diffstat (limited to 'sys/dev/sk')
-rw-r--r--sys/dev/sk/if_sk.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/sys/dev/sk/if_sk.c b/sys/dev/sk/if_sk.c
index bcc4b03..0daf42e 100644
--- a/sys/dev/sk/if_sk.c
+++ b/sys/dev/sk/if_sk.c
@@ -823,6 +823,7 @@ sk_setmulti(sc_if)
hashes[1] = 0xFFFFFFFF;
} else {
i = 1;
+ IF_ADDR_LOCK(ifp);
TAILQ_FOREACH_REVERSE(ifma, &ifp->if_multiaddrs, ifmultihead, ifma_link) {
if (ifma->ifma_addr->sa_family != AF_LINK)
continue;
@@ -855,6 +856,7 @@ sk_setmulti(sc_if)
else
hashes[1] |= (1 << (h - 32));
}
+ IF_ADDR_UNLOCK(ifp);
}
switch(sc->sk_type) {
OpenPOWER on IntegriCloud