summaryrefslogtreecommitdiffstats
path: root/sys/dev/sge/if_sge.c
diff options
context:
space:
mode:
authoryongari <yongari@FreeBSD.org>2010-10-14 18:31:40 +0000
committeryongari <yongari@FreeBSD.org>2010-10-14 18:31:40 +0000
commit92023f4cc9e471aa4ad6bf4362c248d8f173e46a (patch)
treea0e4e25c77486cf23be8641eed71e4b366b6078f /sys/dev/sge/if_sge.c
parenta4ebafd9602a429881d9def23f17e029dcc762ce (diff)
downloadFreeBSD-src-92023f4cc9e471aa4ad6bf4362c248d8f173e46a.zip
FreeBSD-src-92023f4cc9e471aa4ad6bf4362c248d8f173e46a.tar.gz
Make sure to not use stale ip/tcp header pointers. The ip/tcp
header parser uses m_pullup(9) to get access to mbuf chain. m_pullup(9) can allocate new mbuf chain and free old one if the space left in the mbuf chain is not enough to hold requested contiguous bytes. Previously drivers can use stale ip/tcp header pointer if m_pullup(9) returned new mbuf chain. Reported by: Andrew Boyer (aboyer <> averesystems dot com) MFC after: 10 days
Diffstat (limited to 'sys/dev/sge/if_sge.c')
-rw-r--r--sys/dev/sge/if_sge.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/sys/dev/sge/if_sge.c b/sys/dev/sge/if_sge.c
index e294edd..e727d05 100644
--- a/sys/dev/sge/if_sge.c
+++ b/sys/dev/sge/if_sge.c
@@ -1457,7 +1457,9 @@ sge_encap(struct sge_softc *sc, struct mbuf **m_head)
* Reset IP checksum and recompute TCP pseudo
* checksum that NDIS specification requires.
*/
+ ip = (struct ip *)(mtod(m, char *) + ip_off);
ip->ip_sum = 0;
+ tcp = (struct tcphdr *)(mtod(m, char *) + poff);
tcp->th_sum = in_pseudo(ip->ip_src.s_addr, ip->ip_dst.s_addr,
htons(IPPROTO_TCP));
*m_head = m;
OpenPOWER on IntegriCloud