diff options
| author | imp <imp@FreeBSD.org> | 2005-09-19 03:10:21 +0000 |
|---|---|---|
| committer | imp <imp@FreeBSD.org> | 2005-09-19 03:10:21 +0000 |
| commit | 4e70215e6bf590140205774753c8b0a1f1fe9a36 (patch) | |
| tree | c3358cebc77043ea8b2a3a5036b02dad6a674b7e /sys/dev/sbsh | |
| parent | 37a0bbb7e543c6b2a2f055d676d5a94f781d7738 (diff) | |
| download | FreeBSD-src-4e70215e6bf590140205774753c8b0a1f1fe9a36.zip FreeBSD-src-4e70215e6bf590140205774753c8b0a1f1fe9a36.tar.gz | |
Make sure that we call if_free(ifp) after bus_teardown_intr. Since we
could get an interrupt after we free the ifp, and the interrupt
handler depended on the ifp being still alive, this could, in theory,
cause a crash. Eliminate this possibility by moving the if_free to
after the bus_teardown_intr() call.
Diffstat (limited to 'sys/dev/sbsh')
| -rw-r--r-- | sys/dev/sbsh/if_sbsh.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sys/dev/sbsh/if_sbsh.c b/sys/dev/sbsh/if_sbsh.c index 03cff46..32b15aa 100644 --- a/sys/dev/sbsh/if_sbsh.c +++ b/sys/dev/sbsh/if_sbsh.c @@ -311,12 +311,13 @@ sbsh_detach(device_t dev) sbsh_stop(sc); ether_ifdetach(ifp); - if_free(ifp); bus_teardown_intr(dev, sc->irq_res, sc->intr_hand); bus_release_resource(dev, SYS_RES_IRQ, 0, sc->irq_res); bus_release_resource(dev, SYS_RES_MEMORY, PCIR_BAR(1), sc->mem_res); + if_free(ifp); + splx(s); return (0); } |
