diff options
author | ru <ru@FreeBSD.org> | 2005-09-15 19:07:10 +0000 |
---|---|---|
committer | ru <ru@FreeBSD.org> | 2005-09-15 19:07:10 +0000 |
commit | 0550cbdbeb0ddd2d62eca570ff73d07163db0212 (patch) | |
tree | 26f11886ca7b2afc5902e7339713a7626e6910af /sys/dev/re | |
parent | e535e11c9f1e82c6daa8b6af94249d2f8cc719c7 (diff) | |
download | FreeBSD-src-0550cbdbeb0ddd2d62eca570ff73d07163db0212.zip FreeBSD-src-0550cbdbeb0ddd2d62eca570ff73d07163db0212.tar.gz |
Don't recommend re_detach() (like in vr(4)) as another
possible method to prevent panicing in interrupt handler
after re_shutdown(), sometimes seen on SMP systems.
This would work here only because re_detach() clears
IFF_UP (to prevent another race) and it was demonstrated
that it's not enough to call vr_detach() in vr_shutdown()
to prevent a panic.
Diffstat (limited to 'sys/dev/re')
-rw-r--r-- | sys/dev/re/if_re.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sys/dev/re/if_re.c b/sys/dev/re/if_re.c index 5f09ff2..7a9aec1 100644 --- a/sys/dev/re/if_re.c +++ b/sys/dev/re/if_re.c @@ -2485,8 +2485,7 @@ re_shutdown(dev) /* * Mark interface as down since otherwise we will panic if * interrupt comes in later on, which can happen in some - * cases. Another option is to call re_detach() instead of - * re_stop(), like ve(4) does. + * cases. */ sc->rl_ifp->if_flags &= ~IFF_UP; RL_UNLOCK(sc); |