diff options
| author | rwatson <rwatson@FreeBSD.org> | 2007-05-28 18:20:15 +0000 |
|---|---|---|
| committer | rwatson <rwatson@FreeBSD.org> | 2007-05-28 18:20:15 +0000 |
| commit | 358827478434c5ae55738d68a4f63ba714783b5b (patch) | |
| tree | 42d0e96a604b1eec23fbae248fba51ac92a1df57 /sys/dev/random/randomdev_soft.c | |
| parent | 3049018c517fcb38cc465ddb57e619b19d3e1a54 (diff) | |
| download | FreeBSD-src-358827478434c5ae55738d68a4f63ba714783b5b.zip FreeBSD-src-358827478434c5ae55738d68a4f63ba714783b5b.tar.gz | |
Don't save SYSCTL_ADD_*() results in a local variable just to throw them
away; preserve the ones that are needed for further calls in the init
function and ignore the rest entirely.
Found with: Coverity Prevent(tm)
CID: 563
Diffstat (limited to 'sys/dev/random/randomdev_soft.c')
| -rw-r--r-- | sys/dev/random/randomdev_soft.c | 24 |
1 files changed, 9 insertions, 15 deletions
diff --git a/sys/dev/random/randomdev_soft.c b/sys/dev/random/randomdev_soft.c index 5a7a6ea..365f3ea 100644 --- a/sys/dev/random/randomdev_soft.c +++ b/sys/dev/random/randomdev_soft.c @@ -119,54 +119,48 @@ random_yarrow_init(void) { int error, i; struct harvest *np; - struct sysctl_oid *o, *random_o, *random_sys_o, *random_sys_harvest_o; + struct sysctl_oid *random_o, *random_sys_o, *random_sys_harvest_o; enum esource e; - o = SYSCTL_ADD_NODE(&random_clist, + random_o = SYSCTL_ADD_NODE(&random_clist, SYSCTL_STATIC_CHILDREN(_kern), OID_AUTO, "random", CTLFLAG_RW, 0, "Software Random Number Generator"); - random_o = o; - random_yarrow_init_alg(&random_clist, random_o); - o = SYSCTL_ADD_NODE(&random_clist, + random_sys_o = SYSCTL_ADD_NODE(&random_clist, SYSCTL_CHILDREN(random_o), OID_AUTO, "sys", CTLFLAG_RW, 0, "Entropy Device Parameters"); - random_sys_o = o; - - o = SYSCTL_ADD_PROC(&random_clist, + SYSCTL_ADD_PROC(&random_clist, SYSCTL_CHILDREN(random_sys_o), OID_AUTO, "seeded", CTLTYPE_INT | CTLFLAG_RW, &random_systat.seeded, 1, random_check_boolean, "I", "Seeded State"); - o = SYSCTL_ADD_NODE(&random_clist, + random_sys_harvest_o = SYSCTL_ADD_NODE(&random_clist, SYSCTL_CHILDREN(random_sys_o), OID_AUTO, "harvest", CTLFLAG_RW, 0, "Entropy Sources"); - random_sys_harvest_o = o; - - o = SYSCTL_ADD_PROC(&random_clist, + SYSCTL_ADD_PROC(&random_clist, SYSCTL_CHILDREN(random_sys_harvest_o), OID_AUTO, "ethernet", CTLTYPE_INT | CTLFLAG_RW, &harvest.ethernet, 1, random_check_boolean, "I", "Harvest NIC entropy"); - o = SYSCTL_ADD_PROC(&random_clist, + SYSCTL_ADD_PROC(&random_clist, SYSCTL_CHILDREN(random_sys_harvest_o), OID_AUTO, "point_to_point", CTLTYPE_INT | CTLFLAG_RW, &harvest.point_to_point, 1, random_check_boolean, "I", "Harvest serial net entropy"); - o = SYSCTL_ADD_PROC(&random_clist, + SYSCTL_ADD_PROC(&random_clist, SYSCTL_CHILDREN(random_sys_harvest_o), OID_AUTO, "interrupt", CTLTYPE_INT | CTLFLAG_RW, &harvest.interrupt, 1, random_check_boolean, "I", "Harvest IRQ entropy"); - o = SYSCTL_ADD_PROC(&random_clist, + SYSCTL_ADD_PROC(&random_clist, SYSCTL_CHILDREN(random_sys_harvest_o), OID_AUTO, "swi", CTLTYPE_INT | CTLFLAG_RW, &harvest.swi, 0, random_check_boolean, "I", |
