diff options
| author | imp <imp@FreeBSD.org> | 2008-12-07 18:32:09 +0000 |
|---|---|---|
| committer | imp <imp@FreeBSD.org> | 2008-12-07 18:32:09 +0000 |
| commit | 09990939a46c3539c1bb818b4bff57a158233de6 (patch) | |
| tree | 83326ac75581ce5edea7b4da7722aa9ceb81c9d8 /sys/dev/pccbb/pccbb_pci.c | |
| parent | 868630039f3335e1079202ef1795b0391612c7e2 (diff) | |
| download | FreeBSD-src-09990939a46c3539c1bb818b4bff57a158233de6.zip FreeBSD-src-09990939a46c3539c1bb818b4bff57a158233de6.tar.gz | |
Use atomic_add_int rather than a simple ++ to ensure no cache races if
the power interrupt and init code waiting for the interrupt are
running on different CPUs. I haven't seen this make any real
difference, but I've also had some reports of odd behavior I can't
otherwise explain. It is an infrequent operation, and certainly
wouldn't hurt.
Diffstat (limited to 'sys/dev/pccbb/pccbb_pci.c')
| -rw-r--r-- | sys/dev/pccbb/pccbb_pci.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/dev/pccbb/pccbb_pci.c b/sys/dev/pccbb/pccbb_pci.c index 5d38921..8c64ef7 100644 --- a/sys/dev/pccbb/pccbb_pci.c +++ b/sys/dev/pccbb/pccbb_pci.c @@ -730,7 +730,7 @@ cbb_pci_filt(void *arg) if (sockevent & CBB_SOCKET_EVENT_POWER) { cbb_clrb(sc, CBB_SOCKET_MASK, CBB_SOCKET_EVENT_POWER); cbb_set(sc, CBB_SOCKET_EVENT, CBB_SOCKET_EVENT_POWER); - sc->powerintr++; + atomic_add_int(&sc->powerintr, 1); wakeup((void *)&sc->powerintr); } retval = FILTER_HANDLED; |
