summaryrefslogtreecommitdiffstats
path: root/sys/dev/mii/bmtphy.c
diff options
context:
space:
mode:
authorglebius <glebius@FreeBSD.org>2013-10-26 18:40:17 +0000
committerglebius <glebius@FreeBSD.org>2013-10-26 18:40:17 +0000
commit6c652d2b3759faec74b92a9314d236fe6c6c8c6e (patch)
tree9820d962804735a61b97b2d9e576f3759cdea60e /sys/dev/mii/bmtphy.c
parent8400f0c9dba857f0bfca2c2dca1e24c59e3d3dcb (diff)
downloadFreeBSD-src-6c652d2b3759faec74b92a9314d236fe6c6c8c6e.zip
FreeBSD-src-6c652d2b3759faec74b92a9314d236fe6c6c8c6e.tar.gz
The MII layer shouldn't care about administrative status of an
interface. Make MII drivers forget about 'struct ifnet'. Later plan is to provide an administrative downcall from ifnet layer into drivers, to inform them about administrative status change. If someone thinks that processing MII events for an administratively down interface is a big problem, then drivers would turn MII processing off. The following MII drivers do evil things, like strcmp() on driver name, so they still need knowledge of ifnet and thus include if_var.h. They all need to be fixed: sys/dev/mii/brgphy.c sys/dev/mii/e1000phy.c sys/dev/mii/ip1000phy.c sys/dev/mii/jmphy.c sys/dev/mii/nsphy.c sys/dev/mii/rgephy.c sys/dev/mii/truephy.c Sponsored by: Netflix Sponsored by: Nginx, Inc.
Diffstat (limited to 'sys/dev/mii/bmtphy.c')
-rw-r--r--sys/dev/mii/bmtphy.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/sys/dev/mii/bmtphy.c b/sys/dev/mii/bmtphy.c
index 81c2bd2..a4e880e 100644
--- a/sys/dev/mii/bmtphy.c
+++ b/sys/dev/mii/bmtphy.c
@@ -159,12 +159,6 @@ bmtphy_service(struct mii_softc *sc, struct mii_data *mii, int cmd)
break;
case MII_MEDIACHG:
- /*
- * If the interface is not up, don't do anything.
- */
- if ((mii->mii_ifp->if_flags & IFF_UP) == 0)
- break;
-
mii_phy_setmedia(sc);
break;
OpenPOWER on IntegriCloud