diff options
| author | joerg <joerg@FreeBSD.org> | 2010-12-10 14:04:41 +0000 |
|---|---|---|
| committer | joerg <joerg@FreeBSD.org> | 2010-12-10 14:04:41 +0000 |
| commit | db0bf4d239a5eeb3a83fece00d92006244b78db8 (patch) | |
| tree | 6b068ac4eadfe9f2d9c846c2e6e0272e60331050 /sys/dev/ieee488 | |
| parent | 5ca06024ea9d116de4204afd530aa81d646cb8d5 (diff) | |
| download | FreeBSD-src-db0bf4d239a5eeb3a83fece00d92006244b78db8.zip FreeBSD-src-db0bf4d239a5eeb3a83fece00d92006244b78db8.tar.gz | |
Fix __retval vs. retval confusion: retval is meant to store the (userland)
pointer where data is to be returned by ibask() (currently unimplemented),
while __retval holds the value returned by the libgpib ibfoo() functions.
The confusion resulted in the ibfoo() functions returning an uninitialized
value except in situations where the GPIB activity has been terminated
abnormally.
MFC after: 3 days
Diffstat (limited to 'sys/dev/ieee488')
| -rw-r--r-- | sys/dev/ieee488/ibfoo.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/dev/ieee488/ibfoo.c b/sys/dev/ieee488/ibfoo.c index 7ae9160..b8ec2bd 100644 --- a/sys/dev/ieee488/ibfoo.c +++ b/sys/dev/ieee488/ibfoo.c @@ -1019,7 +1019,7 @@ gpib_ib_ioctl(struct cdev *dev, u_long cmd, caddr_t data, int fflag, struct thre ap->__iberr = 0; ap->__ibsta = 0; ap->__ibcnt = 0; - ap->retval = 0; + ap->__retval = 0; if (ap->__field & __F_TMO) { if (ap->tmo < 0 || ap->tmo >= max_timeouts) |
