summaryrefslogtreecommitdiffstats
path: root/sys/dev/hwpmc
diff options
context:
space:
mode:
authorjkoshy <jkoshy@FreeBSD.org>2006-03-16 16:32:56 +0000
committerjkoshy <jkoshy@FreeBSD.org>2006-03-16 16:32:56 +0000
commit48046f6ef352edc95ccc97365458090f2f9d82b0 (patch)
tree0de5de0026f939ba2e0990955320116cc18af5d8 /sys/dev/hwpmc
parentd544d085d24df141503183b9ece7de8672949180 (diff)
downloadFreeBSD-src-48046f6ef352edc95ccc97365458090f2f9d82b0.zip
FreeBSD-src-48046f6ef352edc95ccc97365458090f2f9d82b0.tar.gz
When compiled with -DDEBUG, only print the old value of a PMC in a
debugging message if the flag PMC_F_OLDVALUE was specified in the PMC_OP_RW request being acted upon. This should fix Coverity bug CID 671. Found by: Coverity Prevent MFC after: 3 weeks
Diffstat (limited to 'sys/dev/hwpmc')
-rw-r--r--sys/dev/hwpmc/hwpmc_mod.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/dev/hwpmc/hwpmc_mod.c b/sys/dev/hwpmc/hwpmc_mod.c
index 9c7b3b2..2a950de 100644
--- a/sys/dev/hwpmc/hwpmc_mod.c
+++ b/sys/dev/hwpmc/hwpmc_mod.c
@@ -3293,7 +3293,7 @@ pmc_syscall_handler(struct thread *td, void *syscall_args)
if (prw.pm_flags & PMC_F_NEWVALUE)
PMCDBG(PMC,OPS,2, "rw id=%d new %jx -> old %jx",
ri, prw.pm_value, oldvalue);
- else
+ else if (prw.pm_flags & PMC_F_OLDVALUE)
PMCDBG(PMC,OPS,2, "rw id=%d -> old %jx", ri, oldvalue);
#endif
OpenPOWER on IntegriCloud