diff options
| author | mux <mux@FreeBSD.org> | 2003-04-08 18:35:51 +0000 |
|---|---|---|
| committer | mux <mux@FreeBSD.org> | 2003-04-08 18:35:51 +0000 |
| commit | 9ca3a50f70046c7f4e4420565582209c05447671 (patch) | |
| tree | 44fc3720426ac9072999805ff845422dbd9af7e6 /sys/dev/fxp | |
| parent | e1dab143cdbe93e42c988892132d8e6f7b73696e (diff) | |
| download | FreeBSD-src-9ca3a50f70046c7f4e4420565582209c05447671.zip FreeBSD-src-9ca3a50f70046c7f4e4420565582209c05447671.tar.gz | |
Add an XXX comment for the atomic operation in the __alpha__
case so that it doesn't confuse more people. Use the more
correct atomic_clear_16() instead of atomic_clear_short().
Diffstat (limited to 'sys/dev/fxp')
| -rw-r--r-- | sys/dev/fxp/if_fxp.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/sys/dev/fxp/if_fxp.c b/sys/dev/fxp/if_fxp.c index 756a1a9..562a8df 100644 --- a/sys/dev/fxp/if_fxp.c +++ b/sys/dev/fxp/if_fxp.c @@ -1383,8 +1383,10 @@ fxp_start(struct ifnet *ifp) * granularities, we must prevent the card from DMA'ing * up the status while we update the command field. * This could cause us to overwrite the completion status. + * XXX This is probably bogus and we're _not_ looking + * for atomicity here. */ - atomic_clear_short(&sc->fxp_desc.tx_last->tx_cb->cb_command, + atomic_clear_16(&sc->fxp_desc.tx_last->tx_cb->cb_command, htole16(FXP_CB_COMMAND_S)); #else sc->fxp_desc.tx_last->tx_cb->cb_command &= |
