diff options
| author | yongari <yongari@FreeBSD.org> | 2010-10-14 18:31:40 +0000 |
|---|---|---|
| committer | yongari <yongari@FreeBSD.org> | 2010-10-14 18:31:40 +0000 |
| commit | 92023f4cc9e471aa4ad6bf4362c248d8f173e46a (patch) | |
| tree | a0e4e25c77486cf23be8641eed71e4b366b6078f /sys/dev/fxp | |
| parent | a4ebafd9602a429881d9def23f17e029dcc762ce (diff) | |
| download | FreeBSD-src-92023f4cc9e471aa4ad6bf4362c248d8f173e46a.zip FreeBSD-src-92023f4cc9e471aa4ad6bf4362c248d8f173e46a.tar.gz | |
Make sure to not use stale ip/tcp header pointers. The ip/tcp
header parser uses m_pullup(9) to get access to mbuf chain.
m_pullup(9) can allocate new mbuf chain and free old one if the
space left in the mbuf chain is not enough to hold requested
contiguous bytes. Previously drivers can use stale ip/tcp header
pointer if m_pullup(9) returned new mbuf chain.
Reported by: Andrew Boyer (aboyer <> averesystems dot com)
MFC after: 10 days
Diffstat (limited to 'sys/dev/fxp')
| -rw-r--r-- | sys/dev/fxp/if_fxp.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sys/dev/fxp/if_fxp.c b/sys/dev/fxp/if_fxp.c index 079ecc1..6904d9a 100644 --- a/sys/dev/fxp/if_fxp.c +++ b/sys/dev/fxp/if_fxp.c @@ -1454,6 +1454,8 @@ fxp_encap(struct fxp_softc *sc, struct mbuf **m_head) * Since 82550/82551 doesn't modify IP length and pseudo * checksum in the first frame driver should compute it. */ + ip = (struct ip *)(mtod(m, char *) + ip_off); + tcp = (struct tcphdr *)(mtod(m, char *) + poff); ip->ip_sum = 0; ip->ip_len = htons(m->m_pkthdr.tso_segsz + (ip->ip_hl << 2) + (tcp->th_off << 2)); |
