summaryrefslogtreecommitdiffstats
path: root/sys/dev/etherswitch/arswitch/arswitch_7240.c
diff options
context:
space:
mode:
authorloos <loos@FreeBSD.org>2013-07-23 14:02:38 +0000
committerloos <loos@FreeBSD.org>2013-07-23 14:02:38 +0000
commitf2b6d4ff8043c142ebc1952e5e9e82cebe630993 (patch)
treeb1002e3e652a1ad1f3941efbe1bd6422481e1c03 /sys/dev/etherswitch/arswitch/arswitch_7240.c
parente4f13850f70c2edd8f1918455575694b72741b3e (diff)
downloadFreeBSD-src-f2b6d4ff8043c142ebc1952e5e9e82cebe630993.zip
FreeBSD-src-f2b6d4ff8043c142ebc1952e5e9e82cebe630993.tar.gz
Fix the arswitch instability problem. It turns out that the
arswitch_writereg() routine was writing the registers in the wrong order. Revert -r241918 as the root problem is now fixed. Remove another workaround from arswitch_ar7240.c. Simplify and fix the code on arswitch_writephy() by using arswitch_writereg(). While here remove a redundant declaration from arswitchvar.h. Approved by: adrian (mentor)
Diffstat (limited to 'sys/dev/etherswitch/arswitch/arswitch_7240.c')
-rw-r--r--sys/dev/etherswitch/arswitch/arswitch_7240.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/sys/dev/etherswitch/arswitch/arswitch_7240.c b/sys/dev/etherswitch/arswitch/arswitch_7240.c
index c8f6426..63a8910 100644
--- a/sys/dev/etherswitch/arswitch/arswitch_7240.c
+++ b/sys/dev/etherswitch/arswitch/arswitch_7240.c
@@ -75,12 +75,6 @@ ar7240_hw_setup(struct arswitch_softc *sc)
arswitch_writereg(sc->sc_dev, AR8X16_REG_CPU_PORT,
AR8X16_CPU_PORT_EN | AR8X16_CPU_MIRROR_DIS);
- /*
- * Let things settle; probing PHY4 doesn't seem reliable
- * without a litle delay.
- */
- DELAY(1000);
-
return (0);
}
OpenPOWER on IntegriCloud