Clean up argument comments for bus_dma_tag_create() calls.

5 files changed, 126 insertions, 83 deletions

diff --git a/sys/dev/buslogic/bt.c b/sys/dev/buslogic/bt.c
index b7bc725..cfcf2e6 100644
--- a/sys/dev/buslogic/bt.c
+++ b/sys/dev/buslogic/bt.c
@@ -705,28 +705,37 @@ bt_init(device_t dev)
 	 */
 
 	/* DMA tag for mapping buffers into device visible space. */
-	if (bus_dma_tag_create(bt->parent_dmat, /*alignment*/1, /*boundary*/0,
-			       /*lowaddr*/BUS_SPACE_MAXADDR,
-			       /*highaddr*/BUS_SPACE_MAXADDR,
-			       /*filter*/NULL, /*filterarg*/NULL,
-			       /*maxsize*/MAXBSIZE, /*nsegments*/BT_NSEG,
-			       /*maxsegsz*/BUS_SPACE_MAXSIZE_32BIT,
-			       /*flags*/BUS_DMA_ALLOCNOW,
-			       &bt->buffer_dmat) != 0) {
+	if (bus_dma_tag_create( /* parent	*/ bt->parent_dmat,
+				/* alignment	*/ 1,
+				/* boundary	*/ 0,
+				/* lowaddr	*/ BUS_SPACE_MAXADDR,
+				/* highaddr	*/ BUS_SPACE_MAXADDR,
+				/* filter	*/ NULL,
+				/* filterarg	*/ NULL,
+				/* maxsize	*/ MAXBSIZE,
+				/* nsegments	*/ BT_NSEG,
+				/* maxsegsz	*/ BUS_SPACE_MAXSIZE_32BIT,
+				/* flags	*/ BUS_DMA_ALLOCNOW,
+				&bt->buffer_dmat) != 0) {
 		goto error_exit;
 	}
 
 	bt->init_level++;
 	/* DMA tag for our mailboxes */
-	if (bus_dma_tag_create(bt->parent_dmat, /*alignment*/1, /*boundary*/0,
-			       /*lowaddr*/bt->mailbox_addrlimit,
-			       /*highaddr*/BUS_SPACE_MAXADDR,
-			       /*filter*/NULL, /*filterarg*/NULL,
-			       bt->num_boxes * (sizeof(bt_mbox_in_t)
-					      + sizeof(bt_mbox_out_t)),
-			       /*nsegments*/1,
-			       /*maxsegsz*/BUS_SPACE_MAXSIZE_32BIT,
-			       /*flags*/0, &bt->mailbox_dmat) != 0) {
+	if (bus_dma_tag_create(	/* parent	*/ bt->parent_dmat,
+				/* alignment	*/ 1,
+				/* boundary	*/ 0,
+				/* lowaddr	*/ bt->mailbox_addrlimit,
+				/* highaddr	*/ BUS_SPACE_MAXADDR,
+				/* filter	*/ NULL,
+				/* filterarg	*/ NULL,
+				/* maxsize	*/ bt->num_boxes *
+						   (sizeof(bt_mbox_in_t) +
+						    sizeof(bt_mbox_out_t)),
+				/* nsegments	*/ 1,
+				/* maxsegsz	*/ BUS_SPACE_MAXSIZE_32BIT,
+				/* flags	*/ 0,
+				&bt->mailbox_dmat) != 0) {
 		goto error_exit;
         }
 
@@ -754,14 +763,19 @@ bt_init(device_t dev)
 	btinitmboxes(bt);
 
 	/* DMA tag for our ccb structures */
-	if (bus_dma_tag_create(bt->parent_dmat, /*alignment*/1, /*boundary*/0,
-			       /*lowaddr*/BUS_SPACE_MAXADDR,
-			       /*highaddr*/BUS_SPACE_MAXADDR,
-			       /*filter*/NULL, /*filterarg*/NULL,
-			       bt->max_ccbs * sizeof(struct bt_ccb),
-			       /*nsegments*/1,
-			       /*maxsegsz*/BUS_SPACE_MAXSIZE_32BIT,
-			       /*flags*/0, &bt->ccb_dmat) != 0) {
+	if (bus_dma_tag_create(	/* parent	*/ bt->parent_dmat,
+				/* alignment	*/ 1,
+				/* boundary	*/ 0,
+				/* lowaddr	*/ BUS_SPACE_MAXADDR,
+				/* highaddr	*/ BUS_SPACE_MAXADDR,
+				/* filter	*/ NULL,
+				/* filterarg	*/ NULL,
+				/* maxsize	*/ bt->max_ccbs *
+						   sizeof(struct bt_ccb),
+				/* nsegments	*/ 1,
+				/* maxsegsz	*/ BUS_SPACE_MAXSIZE_32BIT,
+				/* flags	*/ 0,
+				&bt->ccb_dmat) != 0) {
 		goto error_exit;
         }
 
@@ -784,13 +798,18 @@ bt_init(device_t dev)
 	bt->init_level++;
 
 	/* DMA tag for our S/G structures.  We allocate in page sized chunks */
-	if (bus_dma_tag_create(bt->parent_dmat, /*alignment*/1, /*boundary*/0,
-			       /*lowaddr*/BUS_SPACE_MAXADDR,
-			       /*highaddr*/BUS_SPACE_MAXADDR,
-			       /*filter*/NULL, /*filterarg*/NULL,
-			       PAGE_SIZE, /*nsegments*/1,
-			       /*maxsegsz*/BUS_SPACE_MAXSIZE_32BIT,
-			       /*flags*/0, &bt->sg_dmat) != 0) {
+	if (bus_dma_tag_create(	/* parent	*/ bt->parent_dmat,
+				/* alignment	*/ 1,
+				/* boundary	*/ 0,
+				/* lowaddr	*/ BUS_SPACE_MAXADDR,
+				/* highaddr	*/ BUS_SPACE_MAXADDR,
+				/* filter	*/ NULL,
+				/* filterarg	*/ NULL,
+				/* maxsize	*/ PAGE_SIZE,
+				/* nsegments	*/ 1,
+				/* maxsegsz	*/ BUS_SPACE_MAXSIZE_32BIT,
+				/* flags	*/ 0,
+				&bt->sg_dmat) != 0) {
 		goto error_exit;
         }
 
diff --git a/sys/dev/buslogic/bt_eisa.c b/sys/dev/buslogic/bt_eisa.c
index a034a5b..a020d01 100644
--- a/sys/dev/buslogic/bt_eisa.c
+++ b/sys/dev/buslogic/bt_eisa.c
@@ -309,14 +309,18 @@ bt_eisa_attach(device_t dev)
 
 	/* Allocate a dmatag for our SCB DMA maps */
 	/* XXX Should be a child of the PCI bus dma tag */
-	if (bus_dma_tag_create(/*parent*/NULL, /*alignment*/1, /*boundary*/0,
-			       /*lowaddr*/BUS_SPACE_MAXADDR_32BIT,
-			       /*highaddr*/BUS_SPACE_MAXADDR,
-			       /*filter*/NULL, /*filterarg*/NULL,
-			       /*maxsize*/BUS_SPACE_MAXSIZE_32BIT,
-			       /*nsegments*/~0,
-			       /*maxsegsz*/BUS_SPACE_MAXSIZE_32BIT,
-			       /*flags*/0, &bt->parent_dmat) != 0) {
+	if (bus_dma_tag_create( /* parent	*/ NULL,
+				/* alignment	*/ 1,
+				/* boundary	*/ 0,
+				/* lowaddr	*/ BUS_SPACE_MAXADDR_32BIT,
+				/* highaddr	*/ BUS_SPACE_MAXADDR,
+				/* filter	*/ NULL,
+				/* filterarg	*/ NULL,
+				/* maxsize	*/ BUS_SPACE_MAXSIZE_32BIT,
+				/* nsegments	*/ ~0,
+				/* maxsegsz	*/ BUS_SPACE_MAXSIZE_32BIT,
+				/* flags	*/ 0,
+				&bt->parent_dmat) != 0) {
 		bt_eisa_release_resources(dev);
 		return -1;
 	}
diff --git a/sys/dev/buslogic/bt_isa.c b/sys/dev/buslogic/bt_isa.c
index f977beb..f76aa16 100644
--- a/sys/dev/buslogic/bt_isa.c
+++ b/sys/dev/buslogic/bt_isa.c
@@ -232,13 +232,18 @@ bt_isa_attach(device_t dev)
 	}
 			
 	/* XXX Should be a child of the ISA or VL bus dma tag */
-	if (bus_dma_tag_create(/*parent*/NULL, /*alignemnt*/1, /*boundary*/0,
-                               lowaddr, /*highaddr*/BUS_SPACE_MAXADDR,
-                               filter, filter_arg,
-                               /*maxsize*/BUS_SPACE_MAXSIZE_32BIT,
-                               /*nsegments*/~0,
-                               /*maxsegsz*/BUS_SPACE_MAXSIZE_32BIT,
-                               /*flags*/0, &bt->parent_dmat) != 0) {
+	if (bus_dma_tag_create(	/* parent	*/ NULL,
+				/* alignemnt	*/ 1,
+				/* boundary	*/ 0,
+				/* lowaddr	*/ lowaddr,
+				/* highaddr	*/ BUS_SPACE_MAXADDR,
+				/* filter	*/ filter,
+				/* filterarg	*/ filter_arg,
+				/* maxsize	*/ BUS_SPACE_MAXSIZE_32BIT,
+				/* nsegments	*/ ~0,
+				/* maxsegsz	*/ BUS_SPACE_MAXSIZE_32BIT,
+				/* flags	*/ 0,
+				&bt->parent_dmat) != 0) {
 		bt_isa_release_resources(dev);
                 return (ENOMEM);
         }                              
@@ -251,16 +256,20 @@ bt_isa_attach(device_t dev)
 
 	if (lowaddr != BUS_SPACE_MAXADDR_32BIT) {
 		/* DMA tag for our sense buffers */
-		if (bus_dma_tag_create(bt->parent_dmat, /*alignment*/1,
-				       /*boundary*/0,
-				       /*lowaddr*/BUS_SPACE_MAXADDR,
-				       /*highaddr*/BUS_SPACE_MAXADDR,
-				       /*filter*/NULL, /*filterarg*/NULL,
-				       bt->max_ccbs
-					   * sizeof(struct scsi_sense_data),
-				       /*nsegments*/1,
-				       /*maxsegsz*/BUS_SPACE_MAXSIZE_32BIT,
-				       /*flags*/0, &bt->sense_dmat) != 0) {
+		if (bus_dma_tag_create(
+				/* parent	*/ bt->parent_dmat,
+				/* alignment	*/ 1,
+				/* boundary	*/ 0,
+				/* lowaddr	*/ BUS_SPACE_MAXADDR,
+				/* highaddr	*/ BUS_SPACE_MAXADDR,
+				/* filter	*/ NULL,
+				/* filterarg	*/ NULL,
+				/* maxsize	*/ bt->max_ccbs *
+						   sizeof(struct scsi_sense_data),
+				/* nsegments	*/ 1,
+				/* maxsegsz	*/ BUS_SPACE_MAXSIZE_32BIT,
+				/* flags	*/ 0,
+				&bt->sense_dmat) != 0) {
 			bt_isa_release_resources(dev);
 			return (ENOMEM);
 		}
diff --git a/sys/dev/buslogic/bt_mca.c b/sys/dev/buslogic/bt_mca.c
index d419690..cf237e1 100644
--- a/sys/dev/buslogic/bt_mca.c
+++ b/sys/dev/buslogic/bt_mca.c
@@ -217,15 +217,18 @@ bt_mca_attach (device_t dev)
 	isa_dmacascade(rman_get_start(bt->drq));
 
 	/* Allocate a dmatag for our CCB DMA maps */
-	if (bus_dma_tag_create(/*parent*/NULL, /*alignemnt*/1, /*boundary*/0,
-			       /*lowaddr*/BUS_SPACE_MAXADDR_24BIT,
-			       /*highaddr*/BUS_SPACE_MAXADDR,
-			       /*filter*/btvlbouncefilter,
-			       /*filterarg*/bt,
-			       /*maxsize*/BUS_SPACE_MAXSIZE_32BIT,
-			       /*nsegments*/~0,
-			       /*maxsegsz*/BUS_SPACE_MAXSIZE_32BIT,
-			       /*flags*/0, &bt->parent_dmat) != 0) {
+	if (bus_dma_tag_create( /* parent	*/ NULL,
+				/* alignemnt	*/ 1,
+				/* boundary	*/ 0,
+				/* lowaddr	*/ BUS_SPACE_MAXADDR_24BIT,
+				/* highaddr	*/ BUS_SPACE_MAXADDR,
+				/* filter	*/ btvlbouncefilter,
+				/* filterarg	*/ bt,
+				/* maxsize	*/ BUS_SPACE_MAXSIZE_32BIT,
+				/* nsegments	*/ ~0,
+				/* maxsegsz	*/ BUS_SPACE_MAXSIZE_32BIT,
+				/* flags	*/ 0,
+				&bt->parent_dmat) != 0) {
 		bt_mca_release_resources(dev);
 		return (ENOMEM);
 	}
@@ -236,15 +239,19 @@ bt_mca_attach (device_t dev)
 	}
 
 	/* DMA tag for our sense buffers */
-	if (bus_dma_tag_create(bt->parent_dmat, /*alignment*/1, 
-			       /*boundary*/0,
-			       /*lowaddr*/BUS_SPACE_MAXADDR,    
-			       /*highaddr*/BUS_SPACE_MAXADDR,   
-			       /*filter*/NULL, /*filterarg*/NULL,
-			       bt->max_ccbs * sizeof(struct scsi_sense_data),
-			       /*nsegments*/1,
-			       /*maxsegsz*/BUS_SPACE_MAXSIZE_32BIT,
-			       /*flags*/0, &bt->sense_dmat) != 0) {
+	if (bus_dma_tag_create(	/* parent	*/ bt->parent_dmat,
+				/* alignment	*/ 1, 
+				/* boundary	*/ 0,
+				/* lowaddr	*/ BUS_SPACE_MAXADDR,    
+				/* highaddr	*/ BUS_SPACE_MAXADDR,   
+				/* filter	*/ NULL,
+				/* filterarg	*/ NULL,
+				/* maxsize	*/ bt->max_ccbs *
+						   sizeof(struct scsi_sense_data),
+				/* nsegments	*/ 1,
+				/* maxsegsz	*/ BUS_SPACE_MAXSIZE_32BIT,
+				/* flags	*/ 0,
+				&bt->sense_dmat) != 0) {
 		bt_mca_release_resources(dev);
 		return (ENOMEM);
 	}
diff --git a/sys/dev/buslogic/bt_pci.c b/sys/dev/buslogic/bt_pci.c
index d3deb70..f2f6158 100644
--- a/sys/dev/buslogic/bt_pci.c
+++ b/sys/dev/buslogic/bt_pci.c
@@ -173,14 +173,18 @@ bt_pci_attach(device_t dev)
 
 	/* Allocate a dmatag for our CCB DMA maps */
 	/* XXX Should be a child of the PCI bus dma tag */
-	if (bus_dma_tag_create(/*parent*/NULL, /*alignemnt*/1, /*boundary*/0,
-			       /*lowaddr*/BUS_SPACE_MAXADDR_32BIT,
-			       /*highaddr*/BUS_SPACE_MAXADDR,
-			       /*filter*/NULL, /*filterarg*/NULL,
-			       /*maxsize*/BUS_SPACE_MAXSIZE_32BIT,
-			       /*nsegments*/~0,
-			       /*maxsegsz*/BUS_SPACE_MAXSIZE_32BIT,
-			       /*flags*/0, &bt->parent_dmat) != 0) {
+	if (bus_dma_tag_create(	/* parent	*/ NULL,
+				/* alignemnt	*/ 1,
+				/* boundary	*/ 0,
+				/* lowaddr	*/ BUS_SPACE_MAXADDR_32BIT,
+				/* highaddr	*/ BUS_SPACE_MAXADDR,
+				/* filter	*/ NULL,
+				/* filterarg	*/ NULL,
+				/* maxsize	*/ BUS_SPACE_MAXSIZE_32BIT,
+				/* nsegments	*/ ~0,
+				/* maxsegsz	*/ BUS_SPACE_MAXSIZE_32BIT,
+				/* flags	*/ 0,
+				&bt->parent_dmat) != 0) {
 		bt_pci_release_resources(dev);
 		return (ENOMEM);
 	}