summaryrefslogtreecommitdiffstats
path: root/sys/dev/amr/amr.c
diff options
context:
space:
mode:
authormsmith <msmith@FreeBSD.org>2000-04-24 19:56:26 +0000
committermsmith <msmith@FreeBSD.org>2000-04-24 19:56:26 +0000
commitcf670bded417ef9f0446fb1326d76f4d9fcdb4cf (patch)
treeafe75c05b855d068f7a506346a77f91edb8cb6c2 /sys/dev/amr/amr.c
parent8fb731fdd700d851fd15c3708ff200be74650dea (diff)
downloadFreeBSD-src-cf670bded417ef9f0446fb1326d76f4d9fcdb4cf.zip
FreeBSD-src-cf670bded417ef9f0446fb1326d76f4d9fcdb4cf.tar.gz
Disable the returning of "wedged" commands; this is wrong and needs to be
rethought.
Diffstat (limited to 'sys/dev/amr/amr.c')
-rw-r--r--sys/dev/amr/amr.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/sys/dev/amr/amr.c b/sys/dev/amr/amr.c
index de6f965..b81403e 100644
--- a/sys/dev/amr/amr.c
+++ b/sys/dev/amr/amr.c
@@ -688,7 +688,13 @@ amr_periodic(void *data)
debug("called");
-
+#if 0
+ /*
+ * XXX this is basically wrong - returning a command that's wedged
+ * leaves us vulnerable to the controller later completing the command
+ * and overwriting memory that may have subsequently been reused.
+ */
+
/*
* Check for commands that are massively late. This will need to be
* revisited if/when we deal with eg. device format commands.
@@ -711,6 +717,7 @@ amr_periodic(void *data)
}
}
splx(s);
+#endif
/* reschedule */
sc->amr_timeout = timeout(amr_periodic, sc, hz);
OpenPOWER on IntegriCloud