diff options
| author | cy <cy@FreeBSD.org> | 2015-10-06 03:41:11 +0000 |
|---|---|---|
| committer | cy <cy@FreeBSD.org> | 2015-10-06 03:41:11 +0000 |
| commit | b09fc0c241c99f57ec17d3ca87519258b4a6dfee (patch) | |
| tree | 9996a7ea379a06c9274af6f5b7be266de2a17c35 /sys/contrib | |
| parent | c3c1533b787ea7520103e13da636bdb284667002 (diff) | |
| download | FreeBSD-src-b09fc0c241c99f57ec17d3ca87519258b4a6dfee.zip FreeBSD-src-b09fc0c241c99f57ec17d3ca87519258b4a6dfee.tar.gz | |
On some interfaces, ipfilter drops UDP packets with zero checkum.
This commit fixes that.
PR: 166372
Submitted by: mk@neon1.net
Reviewed by: Darren Reed <darrenr@reed.wattle.id.au>
MFC after: 1 week
Diffstat (limited to 'sys/contrib')
| -rw-r--r-- | sys/contrib/ipfilter/netinet/ip_fil_freebsd.c | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/sys/contrib/ipfilter/netinet/ip_fil_freebsd.c b/sys/contrib/ipfilter/netinet/ip_fil_freebsd.c index 93ea572..a5d3f44 100644 --- a/sys/contrib/ipfilter/netinet/ip_fil_freebsd.c +++ b/sys/contrib/ipfilter/netinet/ip_fil_freebsd.c @@ -1104,6 +1104,22 @@ ipf_checkv4sum(fin) return -1; } if (m->m_pkthdr.csum_flags & CSUM_DATA_VALID) { + /* Depending on the driver, UDP may have zero checksum */ + if (fin->fin_p == IPPROTO_UDP && (fin->fin_flx & + (FI_FRAG|FI_SHORT|FI_BAD)) == 0) { + udphdr_t *udp = fin->fin_dp; + if (udp->uh_sum == 0) { + /* + * we're good no matter what the hardware + * checksum flags and csum_data say (handling + * of csum_data for zero UDP checksum is not + * consistent across all drivers) + */ + fin->fin_cksum = 1; + return 0; + } + } + if (m->m_pkthdr.csum_flags & CSUM_PSEUDO_HDR) sum = m->m_pkthdr.csum_data; else |
