diff options
| author | phk <phk@FreeBSD.org> | 2004-08-14 08:38:17 +0000 |
|---|---|---|
| committer | phk <phk@FreeBSD.org> | 2004-08-14 08:38:17 +0000 |
| commit | 9ec2799bcc08f8703844be561ca32554c6808a29 (patch) | |
| tree | b117488458542ba626e6423e9d4b7b4400b7aa4b /sys/compat | |
| parent | 1874b31277fe1c44e4cfde1280746d71db29de19 (diff) | |
| download | FreeBSD-src-9ec2799bcc08f8703844be561ca32554c6808a29.zip FreeBSD-src-9ec2799bcc08f8703844be561ca32554c6808a29.tar.gz | |
Add XXX comment about findcdev() misuse.
Diffstat (limited to 'sys/compat')
| -rw-r--r-- | sys/compat/linux/linux_stats.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/sys/compat/linux/linux_stats.c b/sys/compat/linux/linux_stats.c index a9545fd..4a78554 100644 --- a/sys/compat/linux/linux_stats.c +++ b/sys/compat/linux/linux_stats.c @@ -364,6 +364,12 @@ linux_ustat(struct thread *td, struct linux_ustat_args *args) * struct cdev *. The struct cdev *that is used now may as well be a truncated * struct cdev *returned from previous syscalls. Just return a bzeroed * ustat in that case. + * + * XXX: findcdev() SHALL not be used this way. Somebody (TM) will + * have to find a better way. It may be that we should stick + * a dev_t into struct mount, and walk the mountlist for a + * perfect match and failing that try again looking for a + * minor-truncated match. */ dev = findcdev(makedev(args->dev >> 8, args->dev & 0xFF)); if (dev != NULL && vfinddev(dev, &vp)) { |
