diff options
| author | rwatson <rwatson@FreeBSD.org> | 2002-06-14 07:24:01 +0000 |
|---|---|---|
| committer | rwatson <rwatson@FreeBSD.org> | 2002-06-14 07:24:01 +0000 |
| commit | 6231c89ca356ca59780afac8c23b8b9333851cfc (patch) | |
| tree | b441405bd7331b95c7e98da4599b76cae040dcb2 /sys/compat | |
| parent | 788e1edafc6a6e7c0d42383d875d787b95a27f08 (diff) | |
| download | FreeBSD-src-6231c89ca356ca59780afac8c23b8b9333851cfc.zip FreeBSD-src-6231c89ca356ca59780afac8c23b8b9333851cfc.tar.gz | |
Add a comment about how we should use vn_open() here instead of directly
invoking VOP_OPEN(). This would reduce code redundancy with the rest
of the kernel, and also is required for MAC to work properly.
Diffstat (limited to 'sys/compat')
| -rw-r--r-- | sys/compat/linux/linux_misc.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/sys/compat/linux/linux_misc.c b/sys/compat/linux/linux_misc.c index d3384c6..c081fc1 100644 --- a/sys/compat/linux/linux_misc.c +++ b/sys/compat/linux/linux_misc.c @@ -302,6 +302,10 @@ linux_uselib(struct thread *td, struct linux_uselib_args *args) if (error) goto cleanup; + /* + * XXX: This should use vn_open() so that it is properly authorized, + * and to reduce code redundancy all over the place here. + */ error = VOP_OPEN(vp, FREAD, td->td_ucred, td); if (error) goto cleanup; |
