Remove fpsetsticky(). This was added for SysV compatibility, but due

to mistakes from day 1, it has always had semantics inconsistent with
SVR4 and its successors.  In particular, given argument M:

- On Solaris and FreeBSD/{alpha,sparc64}, it clobbers the old flags
  and *sets* the new flag word to M.  (NetBSD, too?)
- On FreeBSD/{amd64,i386}, it *clears* the flags that are specified in M
  and leaves the remaining flags unchanged (modulo a small bug on amd64.)
- On FreeBSD/ia64, it is not implemented.

There is no way to fix fpsetsticky() to DTRT for both old FreeBSD apps
and apps ported from other operating systems, so the best approach
seems to be to kill the function and fix any apps that break.  I
couldn't find any ports that use it, and any such ports would already
be broken on FreeBSD/ia64 and Linux anyway.

By the way, the routine has always been undocumented in FreeBSD,
except for an MLINK to a manpage that doesn't describe it.  This
manpage has stated since 5.3-RELEASE that the functions it describes
are deprecated, so that must mean that functions that it is *supposed*
to describe but doesn't are even *more* deprecated.  ;-)

Note that fpresetsticky() has been retained on FreeBSD/i386.  As far
as I can tell, no other operating systems or ports of FreeBSD
implement it, so there's nothing for it to be inconsistent with.

PR:		75862
Suggested by:	bde

1 files changed, 0 insertions, 20 deletions

diff --git a/sys/amd64/include/ieeefp.h b/sys/amd64/include/ieeefp.h
index bfa80aa..6da7e7f 100644
--- a/sys/amd64/include/ieeefp.h
+++ b/sys/amd64/include/ieeefp.h
@@ -249,25 +249,6 @@ __fpgetsticky(void)
 	return (_ex);
 }
 
-/* Note that this should really be called fpresetsticky() */
-static __inline__ fp_except_t
-__fpsetsticky(fp_except_t _m)
-{
-	unsigned _env[7];
-	unsigned int _mxcsr;
-	fp_except_t _p;
-
-	__fnstenv(_env);
-	_p = _env[FP_STKY_REG] & _m;
-	__stmxcsr(&_mxcsr);
-	_p |= _mxcsr & SSE_STKY_FLD;
-	_env[FP_STKY_REG] &= ~_m;
-	__fldenv(_env);
-	_mxcsr &= ~_m;
-	__ldmxcsr(&_mxcsr);
-	return (_p);
-}
-
 #endif /* __GNUCLIKE_ASM && __CC_SUPPORTS___INLINE__ && !__cplusplus */
 
 #if !defined(__IEEEFP_NOINLINES__) && !defined(__cplusplus) \
@@ -280,7 +261,6 @@ __fpsetsticky(fp_except_t _m)
 #define	fpgetmask()	__fpgetmask()
 #define	fpsetmask(_m)	__fpsetmask(_m)
 #define	fpgetsticky()	__fpgetsticky()
-#define	fpsetsticky(_m)	__fpsetsticky(_m)
 
 /* Suppress prototypes in the MI header. */
 #define	_IEEEFP_INLINED_	1