summaryrefslogtreecommitdiffstats
path: root/sys/amd64/include/critical.h
diff options
context:
space:
mode:
authorrwatson <rwatson@FreeBSD.org>2004-07-27 16:41:01 +0000
committerrwatson <rwatson@FreeBSD.org>2004-07-27 16:41:01 +0000
commit4ab080249a9f183254e39905e915442e3e7490d1 (patch)
treede9f7b08c7ab02bd97e32e53b40a626c8216f214 /sys/amd64/include/critical.h
parent8feaacec0cd088d29781dc3559e0d2adef8602a3 (diff)
downloadFreeBSD-src-4ab080249a9f183254e39905e915442e3e7490d1.zip
FreeBSD-src-4ab080249a9f183254e39905e915442e3e7490d1.tar.gz
Pass a thread argument into cpu_critical_{enter,exit}() rather than
dereference curthread. It is called only from critical_{enter,exit}(), which already dereferences curthread. This doesn't seem to affect SMP performance in my benchmarks, but improves MySQL transaction throughput by about 1% on UP on my Xeon. Head nodding: jhb, bmilekic
Diffstat (limited to 'sys/amd64/include/critical.h')
-rw-r--r--sys/amd64/include/critical.h13
1 files changed, 7 insertions, 6 deletions
diff --git a/sys/amd64/include/critical.h b/sys/amd64/include/critical.h
index 3b2d4727..0e02e1f 100644
--- a/sys/amd64/include/critical.h
+++ b/sys/amd64/include/critical.h
@@ -55,9 +55,10 @@ void cpu_critical_fork_exit(void);
* of td_critnest, prior to it being incremented to 1.
*/
static __inline void
-cpu_critical_enter(void)
+cpu_critical_enter(struct thread *td)
{
- curthread->td_md.md_savecrit = intr_disable();
+
+ td->td_md.md_savecrit = intr_disable();
}
/*
@@ -68,15 +69,15 @@ cpu_critical_enter(void)
* exiting the last critical section.
*/
static __inline void
-cpu_critical_exit(void)
+cpu_critical_exit(struct thread *td)
{
- intr_restore(curthread->td_md.md_savecrit);
+ intr_restore(td->td_md.md_savecrit);
}
#else /* !__GNUC__ */
-void cpu_critical_enter(void);
-void cpu_critical_exit(void);
+void cpu_critical_enter(struct thread *td);
+void cpu_critical_exit(struct thread *td);
#endif /* __GNUC__ */
OpenPOWER on IntegriCloud