diff options
| author | bdrewery <bdrewery@FreeBSD.org> | 2015-10-15 22:49:56 +0000 |
|---|---|---|
| committer | bdrewery <bdrewery@FreeBSD.org> | 2015-10-15 22:49:56 +0000 |
| commit | 1b224bebd4cbe6d294a9ab56a4578d337ea4f611 (patch) | |
| tree | d1ed4765ab06d83c34f881401f2494d1f0bcfaaf /share/mk/bsd.files.mk | |
| parent | 2dbdb62ad1b182f1a173c7e46f0fc55e6cfe3a5d (diff) | |
| download | FreeBSD-src-1b224bebd4cbe6d294a9ab56a4578d337ea4f611.zip FreeBSD-src-1b224bebd4cbe6d294a9ab56a4578d337ea4f611.tar.gz | |
Make installing to a non-existent directory an error.
Before this, if a file was installed to DESTDIR/some/dir and that directory
was missing due to not having ran 'make distrib-dirs' yet, the file would
be installed as 'some/dir'. For something like bsd.incs.mk with INCLUDEDIR
being a sub-directory of /usr/include, this could result in all of the headers
being installed to a file rather than getting a directory of them.
Now it will error that the file/directory does not exist rather than hide
the issue.
Another option being discussed is to implement GNU's install -D flag which
would auto create any missing directories.
This is a mitigation of the problem. The proper order to the build is to
run 'make distrib-dirs' first, but that can be forgotten if building from
a sub-directory after updating the source code to the latest revision.
MFC after: 2 weeks
Sponsored by: EMC / Isilon Storage Division
Diffstat (limited to 'share/mk/bsd.files.mk')
| -rw-r--r-- | share/mk/bsd.files.mk | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/share/mk/bsd.files.mk b/share/mk/bsd.files.mk index b9379d9..6a6c66a 100644 --- a/share/mk/bsd.files.mk +++ b/share/mk/bsd.files.mk @@ -75,7 +75,7 @@ _${group}INS: ${_${group}FILES} ${DESTDIR}${${group}DIR}/${${group}NAME} .else ${INSTALL} -o ${${group}OWN} -g ${${group}GRP} \ - -m ${${group}MODE} ${.ALLSRC} ${DESTDIR}${${group}DIR} + -m ${${group}MODE} ${.ALLSRC} ${DESTDIR}${${group}DIR}/ .endif .endif |
