diff options
author | arybchik <arybchik@FreeBSD.org> | 2015-05-21 09:21:05 +0000 |
---|---|---|
committer | arybchik <arybchik@FreeBSD.org> | 2015-05-21 09:21:05 +0000 |
commit | 446dd8d19427cbc7fbe01ffd749b75171f08c5f8 (patch) | |
tree | 4313e47debe14ce7bb631981c26d3a5d297bf486 /share/mk/bsd.crunchgen.mk | |
parent | db9589182b524f024f29cb27de0a6a2c5ed228e1 (diff) | |
download | FreeBSD-src-446dd8d19427cbc7fbe01ffd749b75171f08c5f8.zip FreeBSD-src-446dd8d19427cbc7fbe01ffd749b75171f08c5f8.tar.gz |
MFC: r283048
sfxge: fix overflow queue freeze
If TxQ lock is obtained, deferred packet list shold be serviced even if
the packet addition fails because of overflow.
Without the patch freeze happens if:
- queue is not blocked (i.e. completion does not trigger unblock and service)
- put-list overflow (1024 entries)
- sfxge_tx_packet_add() acquires TxQ lock just as it is released it in
sfxge_tx_qdpl_service() on the second CPU but before pending check
- sfxge_tx_packet_add() swizzles put-list to get-list, fails because of
non-tcp get-list overflow and returns without packet list service
- sfxge_tx_qdpl_service() on the second CPU checks that there are no
pending packets in the put-list and returns
Other possible solution is to guaranee that maximum length of the put-list
is less than maximum length of any get-list.
Sponsored by: Solarflare Communications, Inc.
Diffstat (limited to 'share/mk/bsd.crunchgen.mk')
0 files changed, 0 insertions, 0 deletions