summaryrefslogtreecommitdiffstats
path: root/sbin
diff options
context:
space:
mode:
authorken <ken@FreeBSD.org>2017-06-26 15:23:12 +0000
committerken <ken@FreeBSD.org>2017-06-26 15:23:12 +0000
commit224b446d37054a07f45ee4aca27fd67b9f3910a8 (patch)
treea4707eb2d483ebb326151cc2ba1463a763f1adbe /sbin
parentcc0ed3af4b7429dde30a2b42632e6f7e260ec0fe (diff)
downloadFreeBSD-src-224b446d37054a07f45ee4aca27fd67b9f3910a8.zip
FreeBSD-src-224b446d37054a07f45ee4aca27fd67b9f3910a8.tar.gz
MFC r320123:
Fix a potential sleep while holding a mutex in the sa(4) driver. If the user issues a MTIOCEXTGET ioctl, and the tape drive in question has a serial number that is longer than 80 characters, we malloc a buffer in saextget() to hold the output of cam_strvis(). Since a mutex is held in that codepath, doing a M_WAITOK malloc could lead to sleeping while holding a mutex. Change it to a M_NOWAIT malloc and bail out if we fail to allocate the memory. Devices with serial numbers longer than 80 bytes are very rare (I don't recall seeing one), so this should be a very unusual case to hit. But it is a bug that should be fixed. sys/cam/scsi/scsi_sa.c: In saextget(), if we need to malloc a buffer to hold the output of cam_strvis(), don't wait for the memory. Fail and return an error if we can't allocate the memory immediately. PR: kern/220094 Submitted by: Jia-Ju Bai <baijiaju1990@163.com> Sponsored by: Spectra Logic
Diffstat (limited to 'sbin')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud