diff options
| author | pjd <pjd@FreeBSD.org> | 2011-01-28 21:51:40 +0000 |
|---|---|---|
| committer | pjd <pjd@FreeBSD.org> | 2011-01-28 21:51:40 +0000 |
| commit | 1c569578be289f33c7a03a91a1967b84f73e73c6 (patch) | |
| tree | 5a859fdbb85b78d212aebaa4dfb583359020f80a /sbin | |
| parent | bc13ed0bfab98e8ff4f210dc7c7f9d5667670fe4 (diff) | |
| download | FreeBSD-src-1c569578be289f33c7a03a91a1967b84f73e73c6.zip FreeBSD-src-1c569578be289f33c7a03a91a1967b84f73e73c6.tar.gz | |
Add comments to places where we treat errors as ciritical, but it is possible
to handle them more gracefully.
MFC after: 1 week
Diffstat (limited to 'sbin')
| -rw-r--r-- | sbin/hastd/primary.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/sbin/hastd/primary.c b/sbin/hastd/primary.c index a4cd172..7929c1f 100644 --- a/sbin/hastd/primary.c +++ b/sbin/hastd/primary.c @@ -796,6 +796,7 @@ hastd_primary(struct hast_resource *res) * Create communication channel between parent and child. */ if (proto_client("socketpair://", &res->hr_ctrl) < 0) { + /* TODO: There's no need for this to be fatal error. */ KEEP_ERRNO((void)pidfile_remove(pfh)); pjdlog_exit(EX_OSERR, "Unable to create control sockets between parent and child"); @@ -804,6 +805,7 @@ hastd_primary(struct hast_resource *res) * Create communication channel between child and parent. */ if (proto_client("socketpair://", &res->hr_event) < 0) { + /* TODO: There's no need for this to be fatal error. */ KEEP_ERRNO((void)pidfile_remove(pfh)); pjdlog_exit(EX_OSERR, "Unable to create event sockets between child and parent"); @@ -811,6 +813,7 @@ hastd_primary(struct hast_resource *res) pid = fork(); if (pid < 0) { + /* TODO: There's no need for this to be fatal error. */ KEEP_ERRNO((void)pidfile_remove(pfh)); pjdlog_exit(EX_TEMPFAIL, "Unable to fork"); } |
