Minimize clock drift between getting and setting time

Submitted by: bde

1 files changed, 26 insertions, 9 deletions

diff --git a/sbin/adjkerntz/adjkerntz.c b/sbin/adjkerntz/adjkerntz.c
index f92ea56..e7ad4a7 100644
--- a/sbin/adjkerntz/adjkerntz.c
+++ b/sbin/adjkerntz/adjkerntz.c
@@ -23,7 +23,7 @@
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  *
- *		$Id$
+ *		$Id: adjkerntz.c,v 1.20 1997/06/10 11:01:13 charnier Exp $
  */
 
 #ifndef lint
@@ -257,8 +257,10 @@ recalculate:
 #ifdef DEBUG
 			fprintf(stderr, "Final diff: %ld secs\n", diff);
 #endif
-			tv.tv_sec += diff;
-			tv.tv_usec = 0;       /* we are restarting here... */
+			/*
+			 * stv is abused as a flag.  The important value
+			 * is in `diff'.
+			 */
 			stv = &tv;
 		}
 	}
@@ -293,13 +295,28 @@ recalculate:
 		}
 	}
 
-	if (   (   (init && (stv != NULL || stz != NULL))
-		|| (stz != NULL && stv == NULL)
-	       )
-	    && settimeofday(stv, stz)
+	if (   (init && (stv != NULL || stz != NULL))
+	    || (stz != NULL && stv == NULL)
 	   ) {
-		syslog(LOG_ERR, "settimeofday: %m");
-		return 1;
+		if (stv != NULL) {
+			/*
+			 * Get the time again, as close as possible to
+			 * adjusting it, to minimise drift.
+			 * XXX we'd better not fail between here and
+			 * restoring disrtcset, since we don't clean up
+			 * anything.
+			 */
+			if (gettimeofday(&tv, (struct timezone *)NULL)) {
+				syslog(LOG_ERR, "gettimeofday: %m");
+				return 1;
+			}
+			tv.tv_sec += diff;
+			stv = &tv;
+		}
+		if (settimeofday(stv, stz)) {
+			syslog(LOG_ERR, "settimeofday: %m");
+			return 1;
+		}
 	}
 
 	/* setting CPU_ADJKERNTZ have a side effect: resettodr(), which */