diff options
| author | andrew <andrew@FreeBSD.org> | 2015-09-01 15:43:56 +0000 |
|---|---|---|
| committer | andrew <andrew@FreeBSD.org> | 2015-09-01 15:43:56 +0000 |
| commit | 1bbb003c01ece98db0c814e1d25db41700274560 (patch) | |
| tree | 7b0886591804a11f17f00680a961dedbca76e59d /libexec | |
| parent | e727a91c32ffc18c950cbe9e3a3c70cb30206467 (diff) | |
| download | FreeBSD-src-1bbb003c01ece98db0c814e1d25db41700274560.zip FreeBSD-src-1bbb003c01ece98db0c814e1d25db41700274560.tar.gz | |
Ensure we use calculate_first_tls_offset, even if the main program doesn't
have TLS program header. This is needed on architectures with Variant I
tls, that is arm, arm64, mips, and powerpc. These place the thread control
block at the start of the buffer and, without this, this data may be
trashed.
This appears to not be an issue on mips or powerpc as they include a second
adjustment to move the thread local data, however this is on arm64 (with a
future change to fix placing this data), and should be on arm. I am unable
to trigger this on arm, even after changing the code to move the data
around to make it more likely to be hit. This is most likely because my
tests didn't use the variable in offset 0.
Reviewed by: kib
MFC after: 1 week
Sponsored by: ABT Systems Ltd
Diffstat (limited to 'libexec')
| -rw-r--r-- | libexec/rtld-elf/rtld.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libexec/rtld-elf/rtld.c b/libexec/rtld-elf/rtld.c index 1d91460..eecfb0f 100644 --- a/libexec/rtld-elf/rtld.c +++ b/libexec/rtld-elf/rtld.c @@ -4611,7 +4611,7 @@ allocate_tls_offset(Obj_Entry *obj) return true; } - if (obj->tlsindex == 1) + if (tls_last_offset == 0) off = calculate_first_tls_offset(obj->tlssize, obj->tlsalign); else off = calculate_tls_offset(tls_last_offset, tls_last_size, |
