The call to setuid(2) subsequently causes setgroups(2) to fail. setgroups(2)

requires super-user access in order to complete successfully.
Move setgroups(2) to execute before setuid(2) so that it is successful.

1 files changed, 2 insertions, 2 deletions

diff --git a/libexec/tftpd/tftpd.c b/libexec/tftpd/tftpd.c
index 29fe0e7..d477d36 100644
--- a/libexec/tftpd/tftpd.c
+++ b/libexec/tftpd/tftpd.c
@@ -286,9 +286,9 @@ main(int argc, char *argv[])
 			syslog(LOG_ERR, "chroot: %s: %m", chroot_dir);
 			exit(1);
 		}
-		chdir( "/" );
-		setuid(nobody->pw_uid);
+		chdir("/");
 		setgroups(1, &nobody->pw_gid);
+		setuid(nobody->pw_uid);
 	}
 
 	len = sizeof(me);